Merge pull request #7774 from joeycozza/next

React: Fix missing props in the Welcome.tsx demo
storybookjs · Aug 29, 2019 · 42a9be0 · 42a9be0 · vercel · Aug 29, 2019
2 parents fbe6294 + 0efc7a2
commit 42a9be0
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 0 deletions.
diff --git a/addons/storyshots/storyshots-core/stories/__snapshots__/storyshot.enzyme.test.js.snap b/addons/storyshots/storyshots-core/stories/__snapshots__/storyshot.enzyme.test.js.snap
@@ -166,6 +166,7 @@ exports[`Storyshots Welcome to Storybook 1`] = `
           onClick={[Function]}
         >
           <button
+            onClick={[Function]}
             style={
               Object {
                 "backgroundColor": "transparent",
@@ -272,6 +273,7 @@ exports[`Storyshots Welcome to Storybook 1`] = `
                 "textDecoration": "none",
               }
             }
+            target="_blank"
           >
             Writing Stories
           </a>

diff --git a/.../storyshots-core/stories/__snapshots__/storyshot.snapshotWithOptionsFunction.test.js.snap b/.../storyshots-core/stories/__snapshots__/storyshot.snapshotWithOptionsFunction.test.js.snap
@@ -139,6 +139,7 @@ exports[`Storyshots Welcome to Storybook 1`] = `
   <p>
     See these sample 
     <button
+      onClick={[Function]}
       style={
         Object {
           "backgroundColor": "transparent",
@@ -233,6 +234,7 @@ exports[`Storyshots Welcome to Storybook 1`] = `
           "textDecoration": "none",
         }
       }
+      target="_blank"
     >
       Writing Stories
     </a>

diff --git a/...toryshots/storyshots-core/stories/required_with_context/__snapshots__/Welcome.stories.foo b/...toryshots/storyshots-core/stories/required_with_context/__snapshots__/Welcome.stories.foo
@@ -43,6 +43,7 @@ exports[`Storyshots Welcome to Storybook 1`] = `
   <p>
     See these sample 
     <button
+      onClick={[Function]}
       style={
         Object {
           "backgroundColor": "transparent",
@@ -137,6 +138,7 @@ exports[`Storyshots Welcome to Storybook 1`] = `
           "textDecoration": "none",
         }
       }
+      target="_blank"
     >
       Writing Stories
     </a>

diff --git a/...ots/storyshots-core/stories/required_with_context/__snapshots__/Welcome.stories.storyshot b/...ots/storyshots-core/stories/required_with_context/__snapshots__/Welcome.stories.storyshot
@@ -43,6 +43,7 @@ exports[`Storyshots Welcome to Storybook 1`] = `
   <p>
     See these sample 
     <button
+      onClick={[Function]}
       style={
         Object {
           "backgroundColor": "transparent",
@@ -137,6 +138,7 @@ exports[`Storyshots Welcome to Storybook 1`] = `
           "textDecoration": "none",
         }
       }
+      target="_blank"
     >
       Writing Stories
     </a>

diff --git a/app/react/src/demo/Welcome.tsx b/app/react/src/demo/Welcome.tsx
@@ -59,6 +59,7 @@ const Link = ({
   children,
   href,
   target,
+  rel,
   ...props
 }: {
   children: string;
@@ -70,6 +71,8 @@ const Link = ({
   <a
     href={href}
     {...props}
+    target={target}
+    rel={rel}
     style={{
       color: '#1474f3',
       textDecoration: 'none',
@@ -101,6 +104,7 @@ const NavButton = ({
   <button
     {...props}
     type="button"
+    onClick={onClick}
     style={{
       color: '#1474f3',
       textDecoration: 'none',