React: Fix missing props in the Welcome.tsx demo #7774
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When the typescript conversion occurred, a few props were destructured out of the props of Link and NavButton (in order to be able to define types for them I assume), but they weren't put into the rendered jsx for their component. (before the typescript conversion they were "automatically" placed in the jsx because of using rest and spread operators with props)
What I did
I explicitly attach those props to the element that needed them.