Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme renders unreadable text on the about page #8211

Closed
stof opened this issue Sep 26, 2019 · 3 comments
Closed

Dark theme renders unreadable text on the about page #8211

stof opened this issue Sep 26, 2019 · 3 comments

Comments

@stof
Copy link
Contributor

stof commented Sep 26, 2019

Describe the bug
Text for <code> is rendered as white text on a white background.

To Reproduce
Steps to reproduce the behavior:

  1. Configure storybook with a dark theme
  2. Click on 'About storybook' in the top-left dropdown

Expected behavior
Text should be readable

Screenshots
image

System:

Environment Info:

  System:
    OS: Linux 4.15 Ubuntu 18.04.3 LTS (Bionic Beaver)
    CPU: (4) x64 Intel(R) Core(TM) i5-6200U CPU @ 2.30GHz
  Binaries:
    Node: 10.16.3 - /usr/bin/node
    Yarn: 1.17.3 - /usr/bin/yarn
    npm: 6.11.3 - ~/.local/bin/npm
  Browsers:
    Firefox: 69.0.1
  npmPackages:
    @storybook/addon-centered: ^5.0.3 => 5.2.1 
    @storybook/addon-knobs: ^5.0.3 => 5.2.1 
    @storybook/addon-notes: ^5.0.3 => 5.2.1 
    @storybook/addon-viewport: ^5.0.3 => 5.2.1 
    @storybook/html: ^5.0.3 => 5.2.1 
    @storybook/theming: ^5.0.3 => 5.2.1
@shilman
Copy link
Member

shilman commented Sep 26, 2019

Good catch! Closing as dupe to #8094

@shilman shilman closed this as completed Sep 26, 2019
Pau1fitz added a commit to Pau1fitz/storybook that referenced this issue Oct 1, 2019
ndelangen added a commit that referenced this issue Oct 2, 2019
@shilman
Copy link
Member

shilman commented Oct 3, 2019

Yay!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.3.0-alpha.7 containing PR #8260 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

shilman pushed a commit that referenced this issue Oct 7, 2019
@shilman
Copy link
Member

shilman commented Oct 7, 2019

Huzzah!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.2 containing PR #8260 that references this issue. Upgrade today to try it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants