Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix inline code styling for dark theme #8260

Merged
merged 1 commit into from
Oct 2, 2019

Conversation

Pau1fitz
Copy link
Contributor

@Pau1fitz Pau1fitz commented Oct 1, 2019

Issues: #8211 #8094

  1. Dark theme renders unreadable text on the about page and
  2. Dark theme missing dark <code> style

What I did

I updated the code styling so it displays correctly on the dark theme. This solves #8211 and #8094.

How to test

Example 1 - 8211

Configure storybook with a dark theme
Click on 'About storybook' in the top-left dropdown

Example 2 - 8094

Configure Storybook to use the dark theme.
Create a story using MDX and use backticks to create a code tag - for example
View story

Screenshots with updated code for referenced issues

Screenshot 2019-10-01 at 17 17 00

Screenshot 2019-10-01 at 17 38 07

@vercel
Copy link

vercel bot commented Oct 1, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-pau1fitz-next.storybook.now.sh

@ndelangen ndelangen added this to the 5.2.x milestone Oct 2, 2019
@ndelangen ndelangen added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 2, 2019
@ndelangen ndelangen merged commit 1f79fec into storybookjs:next Oct 2, 2019
@shilman shilman changed the title #8211 UI: Fix inline code styling for dark theme Oct 2, 2019
@sanchez
Copy link

sanchez commented Oct 3, 2019

This has broken larger code blocks even more than before:
image

@ndelangen
Copy link
Member

@Pau1fitz do you think you could help us address @sanchez report?

@sanchez
Copy link

sanchez commented Oct 3, 2019

I think it may be due to a collision with Bulma and their CSS Selector for .tag which is also used in the code window?

I will have a look tomorrow and see if I can explore the issue further

@Pau1fitz
Copy link
Contributor Author

Pau1fitz commented Oct 3, 2019

@ndelangen sure. I saw @sanchez comment here and assumed it was due to an issue with another library he is using.

@sanchez
Copy link

sanchez commented Oct 3, 2019

Yeah it's my bad, trying to keep track of what is from another library and storybook

@sanchez
Copy link

sanchez commented Oct 3, 2019

Yeah it looks like was an issue with the Bulma .tag selector and the code snippet also using the .tag selector as well! Thanks team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch theming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants