Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addonlinks repo #1021

Merged
merged 23 commits into from
May 12, 2017
Merged

Add addonlinks repo #1021

merged 23 commits into from
May 12, 2017

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented May 11, 2017

Issue: #1016

What I did

ADD addon-links to the repo

How to test

npm install
npm run bootstrap
cd examples/cra-storybook
npm run storybook

Click on stories link in Welcome story.

thani-sh and others added 23 commits August 2, 2016 13:03
Use storybook for the example
Update the README
Update all dependencies 🌴
( nothing to update :P )
…19.0

@kadira/storybook@2.19.0 untested ⚠️
…20.0

@kadira/storybook@2.20.0 untested ⚠️
…20.1

@kadira/storybook@2.20.1 untested ⚠️
@codecov
Copy link

codecov bot commented May 11, 2017

Codecov Report

Merging #1021 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1021      +/-   ##
==========================================
- Coverage   12.61%   12.56%   -0.05%     
==========================================
  Files         192      196       +4     
  Lines        4425     4442      +17     
  Branches      707      711       +4     
==========================================
  Hits          558      558              
- Misses       3242     3255      +13     
- Partials      625      629       +4
Impacted Files Coverage Δ
packages/addon-links/register.js 0% <0%> (ø)
packages/addon-links/src/manager.js 0% <0%> (ø)
packages/addon-links/src/index.js 0% <0%> (ø)
packages/addon-links/src/preview.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9311fe...663b8ca. Read the comment docs.

@ndelangen ndelangen requested a review from shilman May 11, 2017 16:12
@ndelangen
Copy link
Member Author

Please review and merge @shilman

@shilman
Copy link
Member

shilman commented May 12, 2017

Thanks @ndelangen! Much appreciated. Will review, merge, and update the documentation tomorrow morning.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested

@shilman shilman merged commit 18e37f2 into master May 12, 2017
@ndelangen ndelangen deleted the add-addonlinks-repo branch May 12, 2017 15:34
@shilman shilman added the misc label May 27, 2017
@ndelangen ndelangen added the cleanup Minor cleanup style change that won't show up in release changelog label May 27, 2017
Copy link

nx-cloud bot commented Sep 18, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 663b8ca. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants