Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove/addon centered #10300

Merged
merged 10 commits into from
Apr 6, 2020
Merged

Remove/addon centered #10300

merged 10 commits into from
Apr 6, 2020

Conversation

ndelangen
Copy link
Member

Issue: addon centered is replaced with the layout parameter

What I did

REMOVE the addon
ADD migration guide
REMOVE addon-centered usage

@ndelangen ndelangen added this to the 6.0 milestone Apr 3, 2020
@ndelangen ndelangen requested a review from shilman April 3, 2020 11:15
@ndelangen ndelangen self-assigned this Apr 3, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2020 •
edited
Loading

Fails
🚫

Please choose only one of these labels: ["BREAKING CHANGE","maintenance"]
🚫 PR is marked with "BREAKING CHANGE" label.

Generated by 🚫 dangerJS against 8ca6e76

@ndelangen ndelangen force-pushed the remove/addon-centered branch from 46a5364 to 4292c7d Compare April 3, 2020 12:44
shilman
shilman approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Onwards and upwards!!

@ndelangen ndelangen merged commit 2d540b9 into next Apr 6, 2020
@ndelangen ndelangen deleted the remove/addon-centered branch April 6, 2020 06:54
@shilman shilman removed maintenance User-facing maintenance tasks BREAKING CHANGE labels Apr 6, 2020
@shilman shilman added the maintenance User-facing maintenance tasks label Apr 6, 2020
@shilman
Copy link
Member

shilman commented Apr 6, 2020

This is going into deprecated-addons, right?

@ndelangen
Copy link
Member Author

yes, done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@alexandrebodin alexandrebodin Awaiting requested review from alexandrebodin

@alterx alterx Awaiting requested review from alterx

@danielduan danielduan Awaiting requested review from danielduan

@igor-dv igor-dv Awaiting requested review from igor-dv

@kazupon kazupon Awaiting requested review from kazupon

@stijnkoopal stijnkoopal Awaiting requested review from stijnkoopal

@usulpro usulpro Awaiting requested review from usulpro

Assignees

@ndelangen ndelangen

Labels
addon: centered maintenance User-facing maintenance tasks
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ndelangen @shilman