Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/addon centered #10300

Merged
merged 10 commits into from
Apr 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
/addons/a11y/ @jbovenschen @codebyalex
/addons/actions/ @rhalff
/addons/backgrounds/ @ndelangen
/addons/centered/ @kazupon
/addons/events/ @z4o4z @ndelangen
/addons/graphql/ @mnmtanish
/addons/info/ @theinterned @z4o4z @UsulPro @dangreenisrael
Expand Down
1 change: 0 additions & 1 deletion .github/autolabeler.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
'addon: a11y': ["addons/a11y/**"]
'addon: actions': ["addons/actions/**"]
'addon: backgrounds': ["addons/backgrounds/**"]
'addon: centered': ["addons/centered/**"]
'addon: events ': ["addons/events/**"]
'addon: graphql ': ["addons/graphql/**"]
'addon: info': ["addons/info/**"]
Expand Down
1 change: 0 additions & 1 deletion ADDONS_SUPPORT.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
| [a11y](addons/a11y) | + | | + | + | + | + | + | + | + | + | + | + |
| [actions](addons/actions) | + | +\* | + | + | + | + | + | + | + | + | + | + |
| [backgrounds](addons/backgrounds) | + | \* | + | + | + | + | + | + | + | + | + | + |
| [centered](addons/centered) | + | | + | + | + | + | | + | | + | + | + |
| [contexts](addons/contexts) | + | | + | | | | | | | | + | + |
| [cssresources](addons/cssresources) | + | | + | + | + | + | + | + | + | + | + | + |
| [design assets](addons/design-assets) | + | | + | + | + | + | + | + | + | + | + | + |
Expand Down
16 changes: 16 additions & 0 deletions MIGRATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,22 @@ StoryOne.story = {

In 6.0 we removed the actions addon decorate API. Actions handles can be configured globaly, for a collection of stories or per story via parameters. The ability to manipulate the data arguments of an event is only relevant in a few frameworks and is not a common enough usecase to be worth the complexity of supporting.

#### Removed addon centered

In 6.0 we removed the centered addon. Centering is now core feature of storybook, that no longer needs an addon.

Remove the addon-centered decorator and instead add a `layout` parameter:

```js
export const MyStory = () => <div>my story</div>;

MyStory.story = {
parameters: { layout: 'centered' },
};

```
Other possible values are: `padded` (default) and `fullscreen`.

## From version 5.2.x to 5.3.x

### To main.js configuration
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ For additional help, join us [in our Discord](https://discord.gg/sMFvFsG) or [Sl
| [a11y](addons/a11y/) | Test components for user accessibility in Storybook |
| [actions](addons/actions/) | Log actions as users interact with components in the Storybook UI |
| [backgrounds](addons/backgrounds/) | Let users choose backgrounds in the Storybook UI |
| [centered](addons/centered/) | Center the alignment of your components within the Storybook UI |
| [contexts](addons/contexts/) | Interactively inject component contexts for stories in the Storybook UI |
| [cssresources](addons/cssresources/) | Dynamically add/remove css resources to the component iframe |
| [design assets](addons/design-assets/) | View images, videos, weblinks alongside your story |
Expand Down
211 changes: 0 additions & 211 deletions addons/centered/README.md

This file was deleted.

25 changes: 0 additions & 25 deletions addons/centered/angular.d.ts

This file was deleted.

3 changes: 0 additions & 3 deletions addons/centered/angular.js

This file was deleted.

2 changes: 0 additions & 2 deletions addons/centered/ember.d.ts

This file was deleted.

1 change: 0 additions & 1 deletion addons/centered/ember.js

This file was deleted.

2 changes: 0 additions & 2 deletions addons/centered/html.d.ts

This file was deleted.

1 change: 0 additions & 1 deletion addons/centered/html.js

This file was deleted.

2 changes: 0 additions & 2 deletions addons/centered/mithril.d.ts

This file was deleted.

1 change: 0 additions & 1 deletion addons/centered/mithril.js

This file was deleted.

73 changes: 0 additions & 73 deletions addons/centered/package.json

This file was deleted.

2 changes: 0 additions & 2 deletions addons/centered/preact.d.ts

This file was deleted.

1 change: 0 additions & 1 deletion addons/centered/preact.js

This file was deleted.

1 change: 0 additions & 1 deletion addons/centered/rax.js

This file was deleted.

2 changes: 0 additions & 2 deletions addons/centered/react.d.ts

This file was deleted.

1 change: 0 additions & 1 deletion addons/centered/react.js

This file was deleted.

Loading