-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed React Fiber deprecation of using ref with stateless function components #1551
Conversation
It seems there is no relation to the code and the failing hooks. Can someone from the maintainers have a look? |
23eac84
to
72e2ba5
Compare
72e2ba5
to
7171775
Compare
Codecov Report
@@ Coverage Diff @@
## master #1551 +/- ##
==========================================
- Coverage 21.34% 21.32% -0.02%
==========================================
Files 244 244
Lines 5378 5378
Branches 658 657 -1
==========================================
- Hits 1148 1147 -1
- Misses 3730 3744 +14
+ Partials 500 487 -13
Continue to review full report at Codecov.
|
7171775
to
c15aaf0
Compare
From what I've checked I've finished the PR a week ago, and since then, I only rebase from |
That's a shame you had no response for so long =( As for reproduction steps, does it work with |
…ook into oriSomething-fix-issue-1539
…mething-fix-issue-1539
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, looks like it's ShortcutsHelp that needed to be converted to class. I fixed this. Thanks a lot anyway!
Issue: #1539
In short, React Fiber deprecated the ability to add ref to a stateless function component.
What I did
Converted
LeftPanel
andShortcuts
from stateless function components toReact.Component
s.It should be said that it seems the documentations of developing storybook slightly outdated and missing some information.
Another thing to mention is that I had to use
eslint-disable
for the components since according to some ESLint React plugin rule they shouldn't be a regularReact.Component
.I hope I did an okay fix. Please, let me know.
How to test
npm install
npm link
lib/ui
and run therenpm link
app/react
and over there do the following:npm i react@next react-dom@next --only=dev
npm link
After the flowing you should create a React project using React Fiber.
Needs over there to set-up storybook and then run
npm link '@storybook/react'
.The errors for issue #1539 should gone
Fix issue 1539