Fix storyshots by moving cacheDirectory to webpack config #1713
Conversation
ndelangen
added
maintenance
|
Hmm, I felt like I had done this already ;) #1350 |
|
RE: testing -- yes this was a storyshots issue, test the various app modes in SS. |
ndelangen
force-pushed
the
fix/1709-cacheDirectory
branch
from
887c572 to
2890dd3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1713 +/- ##
==========================================
- Coverage 21.24% 21.23% -0.02%
==========================================
Files 252 252
Lines 5700 5698 -2
Branches 685 682 -3
==========================================
- Hits 1211 1210 -1
- Misses 3947 3975 +28
+ Partials 542 513 -29
Continue to review full report at Codecov.
|
| @@ -3,7 +3,6 @@ const findCacheDir = require('find-cache-dir'); | |||
| module.exports = { | |||
There was a problem hiding this comment.
Remove unused findCacheDir above.
app/vue/src/server/config.js
Outdated
| @@ -11,10 +12,16 @@ const logger = console; | |||
| // (inside working directory) if a config path is not provided. | |||
| export default function(configType, baseConfig, configDir) { | |||
| const config = baseConfig; | |||
|
|
|||
app/vue/src/server/config.js
Outdated
| const babelConfig = loadBabelConfig(configDir); | ||
| config.module.rules[0].query = babelConfig; | ||
|
|
||
| config.module.rules[0].query = { |
There was a problem hiding this comment.
Shouldn't this be applied to the react app too?
|
Seems like we |
|
That's what I get when I remove this line: Seems doable, I'll try to handle it |
|
Here it is #1715 |
|
❤️ Could we have a patch release? :D |
shilman
changed the title
fixes: #1709
What I did
Moved cacheDirectory back to webpack config from babel config
How to test
See issue (I think it should be apparent when using storyshots?)