-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix storyshots by moving cacheDirectory to webpack config #1713
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
/* eslint-disable global-require, import/no-dynamic-require */ | ||
import fs from 'fs'; | ||
import path from 'path'; | ||
import findCacheDir from 'find-cache-dir'; | ||
import loadBabelConfig from './babel_config'; | ||
|
||
// avoid ESLint errors | ||
|
@@ -11,10 +12,16 @@ const logger = console; | |
// (inside working directory) if a config path is not provided. | ||
export default function(configType, baseConfig, configDir) { | ||
const config = baseConfig; | ||
|
||
const babelConfig = loadBabelConfig(configDir); | ||
config.module.rules[0].query = babelConfig; | ||
|
||
config.module.rules[0].query = { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't this be applied to the react app too? |
||
// This is a feature of `babel-loader` for webpack (not Babel itself). | ||
// It enables a cache directory for faster-rebuilds | ||
// `find-cache-dir` will create the cache directory under the node_modules directory. | ||
cacheDirectory: findCacheDir({ name: 'react-storybook' }), | ||
...babelConfig, | ||
}; | ||
|
||
// Check whether a config.js file exists inside the storybook | ||
// config directory and throw an error if it's not. | ||
const storybookConfigPath = path.resolve(configDir, 'config.js'); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,6 @@ const findCacheDir = require('find-cache-dir'); | |
module.exports = { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove unused findCacheDir above. |
||
// Don't try to find .babelrc because we want to force this configuration. | ||
babelrc: false, | ||
cacheDirectory: findCacheDir({ name: 'react-storybook' }), | ||
presets: [ | ||
[ | ||
require.resolve('babel-preset-env'), | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra space.