Revert "Move . to lint:js and lint:md"

[ndelangen]

This reverts commit 7b03831.

Issue: The precommit hooks now run yarn lint on ALL files, not just the changed ones.

What I did

reverted the change see above

[nx-cloud]

☁️ Nx Cloud Report

CI ran the following commands for commit 496b4a4. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 1 target

• nx run-many --target=prepare --all --parallel --max-parallel=15 -- --optimized

---

Sent with 💌 from NxCloud.

[IanVS]

Oh I didn't realize there's a pre-commit hook. It's kind of a bummer to use the same npm script for linting in CI and also linting individual files, since the cache will be constantly cleaned out due to running eslint against different files. I wonder if it might be possible to create a separate script for the pre-commit hook, with a different cache-location. Would you be willing to review a PR to try it out if I work on that real quick?

[ndelangen]

constantly cleaned out due to running eslint against different files.

I am unaware of this. I'd assume eslint would keep a cache based on files, so running ona subset of files would not clear the cache. Is this an assumption? or do you have a link to the docs about this?

[IanVS]

That's how it used to work, I'll do a little investigating.

[ndelangen]

We could change the precommit hook of course, it's configured here:

storybook/package.json

Lines 88 to 95 in 7c87145

	"lint-staged": {
	"*.{html,js,json,jsx,mjs,ts,tsx}": [
	"yarn lint:js --fix"
	],
	"package.json": [
	"yarn lint:package"
	]
	},

[IanVS]

Alright cool, either things changed or I was just wrong, but changing the target does not remove the cache. But running --fix does remove the file(s) from the cache (https://eslint.org/docs/user-guide/command-line-interface#--cache), but that's not a huge deal as long as husky is only running on the files that changed (oops).

I've opened an alternative to this revert PR at #17662. Please let me know what you think.