Prevent lint hook from running on all files #17662
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17661
What I did
7b03831 caused eslint to run against all files during the husky hook.
This PR adds a new
lint:js:cmd
script which is the same as thelint:js
from before the commit above, which means it does not specify a target and can therefore be used in the pre-commit hook. This also allows us to follow the "principle of least surprise" in thatyarn lint:js
will run against all files.I was concerned initially that running eslint against a different target, using the same cache location, would invalidate/evict the entire cache. Turns out it doesn't, and that it only evicts the individual files being linted (and then, only because
--fix
is being used).