Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sidebar header wrapping #1962

Merged
merged 2 commits into from
Oct 4, 2017
Merged

Fix sidebar header wrapping #1962

merged 2 commits into from
Oct 4, 2017

Conversation

Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi commented Oct 3, 2017

Issue: #1961

What I did

This partially reverts changes from #1769 while keeping the height alignment itself

How to test

Open cra-kitchen-sink and resize stories panel

image

@codecov
Copy link

codecov bot commented Oct 3, 2017

Codecov Report

Merging #1962 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1962   +/-   ##
=======================================
  Coverage   21.38%   21.38%           
=======================================
  Files         262      262           
  Lines        5757     5757           
  Branches      697      691    -6     
=======================================
  Hits         1231     1231           
- Misses       3978     3995   +17     
+ Partials      548      531   -17
Impacted Files Coverage Δ
.../ui/src/modules/ui/components/left_panel/header.js 29.62% <ø> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8.1% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 21% <0%> (ø) ⬆️
...s/left_panel/stories_tree/tree_decorators_utils.js 45.23% <0%> (ø) ⬆️
lib/components/src/navigation/menu_link.js 0% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 24.13% <0%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c0e443...c2884d5. Read the comment docs.

cursor: 'pointer',
padding: 0,
padding: '5px',
margin: 0,
overflow: 'hidden',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like text-overflow: ellipsis could be helpful so it wouldn't break into multiple lines?

Copy link
Member Author

@Hypnosphi Hypnosphi Oct 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's actually better when it wraps as it did before:
screen shot 2017-10-04 at 01 23 21

@Hypnosphi Hypnosphi merged commit f5ae89d into master Oct 4, 2017
@Hypnosphi Hypnosphi deleted the fix-header-wrapping branch October 4, 2017 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants