Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sidebar header wrapping #1962

Merged
merged 2 commits into from
Oct 4, 2017
Merged

Fix sidebar header wrapping #1962

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea99cdd
Fix sidebar header wrapping
Hypnosphi Oct 3, 2017
c2884d5
Merge branch 'master' into fix-header-wrapping
Hypnosphi Oct 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/ui/src/modules/ui/components/left_panel/header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const wrapperStyle = {
background: '#F7F7F7',
marginBottom: 10,
display: 'flex',
height: 27,
};

const headingStyle = {
Expand All @@ -16,8 +15,9 @@ const headingStyle = {
fontSize: '12px',
fontWeight: 'bolder',
color: '#828282',
textAlign: 'center',
cursor: 'pointer',
padding: 0,
padding: '5px',
margin: 0,
overflow: 'hidden',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like text-overflow: ellipsis could be helpful so it wouldn't break into multiple lines?

Copy link
Member Author

@Hypnosphi Hypnosphi Oct 4, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's actually better when it wraps as it did before:
screen shot 2017-10-04 at 01 23 21

};
Expand All @@ -37,6 +37,7 @@ const shortcutIconStyle = {
backgroundColor: 'inherit',
outline: 0,
width: 30,
flexShrink: 0,
};

const linkStyle = {
Expand Down