Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types: Fix React.ReactElement not found #23967

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

abu-osos
Copy link

Closes #23961

What I did

Just imported the React to the api.ts type file, since it's missing the import

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • [ x] stories
  • [x ] unit tests
  • [x ] integration tests
  • [x ] end-to-end tests

Manual testing

No manual test is mandotory since it's a type issue

-->

Documentation

Not applicable

Checklist for Maintainers

  • [x ] When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • [x ] Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@ndelangen ndelangen self-assigned this Aug 28, 2023
@ndelangen
Copy link
Member

I suspect the original issue was related to some typescript ESM compatibility setting maybe.

Digging into this, it seems to me that @storybook/types should have a dependency on @types/react, because it currently has none, nor a peerDependenncy.

@ghengeveld recently ran into an issue where they tried to register an addon in a react18 project and had issues with FC not accepting children.
I'm not sure this change would really fix that problem, but it's a step in the right direction.

@ndelangen ndelangen changed the title [bug]: React.ReactElement not found issue Types: Fix React.ReactElement not found issue Aug 28, 2023
@ndelangen ndelangen changed the title Types: Fix React.ReactElement not found issue Types: Fix React.ReactElement not found Aug 28, 2023
@ndelangen ndelangen merged commit 29bc724 into storybookjs:next Aug 28, 2023
@github-actions github-actions bot mentioned this pull request Aug 28, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: 'React' has no exported member named 'ReactElement'
3 participants