Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types: Revert "Fix React.ReactElement not found" #23967 #24041

Closed
wants to merge 1 commit into from

Conversation

JReinhold
Copy link
Contributor

Reverts #23967

It broke local sandbox linking in the monorepo for some of the React sandboxes, at least the react-vite-based ones.

@JReinhold JReinhold self-assigned this Sep 1, 2023
@JReinhold JReinhold added maintenance User-facing maintenance tasks react typescript ci:normal labels Sep 1, 2023
@JReinhold JReinhold changed the title Revert "Types: Fix React.ReactElement not found" Types: Revert "Fix React.ReactElement not found" #23967 Sep 1, 2023
@ndelangen
Copy link
Member

@JReinhold perhaps we just remove the react dependency?

@JReinhold
Copy link
Contributor Author

@ndelangen yes, that works too. #24042

@JReinhold JReinhold closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants