-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue3: Introduce portable stories API #25443
Conversation
4f43cff
to
92f412d
Compare
Docs: Vue 3 Unit testing changes for Portable stories
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great -- fantastic work @yannbf !!! 💪
4cbaed6
to
dbbf2dc
Compare
i was waiting for this @yannbf finally Good Job you did not even need my help |
* import { render } from '@testing-library/vue'; | ||
* import { composeStory } from '@storybook/vue3'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However it is time to fix the render function in Vue render to match the official test api, there is a bit of issue here
I find that the testing-library/vue is more legit that the render function in @storybook/vue3
Also i suggest to rename @storybook/vue3 , @storybook/vue, to match with vue current naming convention. and rename @storybook/vue to @storybook/vue2.7 . we need to be consistent with other api so users won't be confused
NB:Dropping Vue 2.7 is recommended
However it is time to fix the render function in Vue render to match the official test api, there is a bit of issue here NB:Dropping Vue 2.7 is recommended |
e97b6b7
to
2162447
Compare
2162447
to
f52e96f
Compare
Relates to storybookjs/testing-vue3#14
What I did
This PR introduces the mechanism which is currently available in https://github.com/storybookjs/testing-vue3 but now as part of the @storybook/vue3 package instead.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>