Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Vue 3 Unit testing changes for Portable stories #25528

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

jonniebigodes
Copy link
Contributor

Follows-up on #25443

What I did

With this pull request, the Unit testing documentation is updated to factor in the mentioned pull request.

What was done:

  • Polished the documentation
  • Adjusted the snippets

@yannbf I assigned you so that you can take a pass at this and follow up on any changes that may be required. One thing, though, the required Storyshots docs changes will come in a separate pull request. Thanks in advance.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@jonniebigodes jonniebigodes added documentation ci:docs Run the CI jobs for documentation checks only. labels Jan 9, 2024
@jonniebigodes jonniebigodes requested a review from yannbf January 9, 2024 20:59
@jonniebigodes jonniebigodes self-assigned this Jan 9, 2024
@yannbf yannbf changed the base branch from next to feat/portable-stories-vue3 January 22, 2024 09:02
@yannbf yannbf force-pushed the feat/portable-stories-vue3 branch from 4f43cff to 92f412d Compare January 22, 2024 09:26
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, thanks a lot <3

@yannbf yannbf merged commit 721818b into feat/portable-stories-vue3 Jan 22, 2024
18 of 19 checks passed
@yannbf yannbf deleted the docs_updates_portable_stories branch January 22, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants