Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Sandbox script should use current version to init (main) #25574

Merged

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jan 12, 2024

Closes #25572

Related: #25560
Related: #25293

Based on:
#25573

What I did

  • ensure sandbox cli command uses latest version of template with the current version of the CLI
  • when the version match, download the after-storybook dir
  • otherwise, download the before-storybook dir, and run init (if requested)

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

  • compile packages in --no-link & publish to a loval registry
  • change the npm registryURl npm config setting to the local registry
  • run npx storybook@latest sandbox in a empty directory
  • expect the command to use the after-storybook dir (it should say so in the terminal output)
  • expect the

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@ndelangen ndelangen changed the title use current version for sandbox cli command CLI: Sandbox script should use current version to init (main) Jan 12, 2024
@ndelangen ndelangen self-assigned this Jan 12, 2024
@ndelangen ndelangen merged commit 894825d into jeppe/upgrade-versioned-main Jan 15, 2024
55 of 56 checks passed
@ndelangen ndelangen deleted the norbert/cli-sandbox-versioned-main branch January 15, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant