Updates storybook-start.js to use child_process instead of shelljs #3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sky-franciscogoncalves
requested review from
danielduan,
Gongreg,
rmevans9 and
tmeasday
as code owners
wuweiweiwu
requested changes
May 5, 2018
| @@ -1,9 +1,9 @@ | |||
| #!/usr/bin/env node | |||
| /* eslint-disable no-console */ | |||
|
|
|||
| /* eslint-disable-next-line camelcase */ | |||
| import child_process from 'child_process'; | |||
There was a problem hiding this comment.
Any reason you don't like camelCase?
There was a problem hiding this comment.
We like camelCase so much we lint in favour of it?
You could possibly import like:
import { spawn } from 'child_process';I think that should make the warning go away?
There was a problem hiding this comment.
@sky-franciscogoncalves Do you think you could fix this minor comment?, and we can get this in the next major release!
Codecov Report
@@ Coverage Diff @@
## master #3527 +/- ##
=======================================
Coverage 37.61% 37.61%
=======================================
Files 459 459
Lines 10377 10377
Branches 928 922 -6
=======================================
Hits 3903 3903
+ Misses 5932 5903 -29
- Partials 542 571 +29
Continue to review full report at Codecov.
|
wuweiweiwu
approved these changes
May 29, 2018
|
Thanks for contributing @sky-franciscogoncalves 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
What I did
Updated react-native's
storybook-start.jsto usechild_processinstead of ShellJS. This is because the later does not support running commands that require interactive input, as you can see here.The need to use these type of commands, started when I updated both Haul and Storybook to their last versions.
How to test
To test this you should update Haul to v1.0.0-rc.0 and Storybook to v4.0.0-alpha.4. Then you should perform
storybook start -p 7007 --haul haul.config.js --platform all. Where the config file follows Haul's new configuration style.Please let me know if I can improve this PR in anyway.