Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates storybook-start.js to use child_process instead of shelljs #3527

Merged
merged 3 commits into from
May 29, 2018
Merged

Updates storybook-start.js to use child_process instead of shelljs #3527

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c08fbd4
Updates storybook-start to use child_process instead of shelljs
sky-franciscogoncalves May 2, 2018
5ce590b
Adds eslint ignore
sky-franciscogoncalves May 2, 2018
d67752c
fix camel case lint
wuweiweiwu May 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions app/react-native/src/bin/storybook-start.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
#!/usr/bin/env node
/* eslint-disable no-console */

import { exec } from 'child_process';
import path from 'path';
import program from 'commander';
import shelljs from 'shelljs';
import Server from '../server';

program
Expand Down Expand Up @@ -95,7 +94,7 @@ if (!program.skipPackager) {
cliCommand = `haul start --config ${program.haul} --platform ${platform}`;
}
// RN packager
shelljs.exec(
exec(
[
cliCommand,
`--projectRoots ${projectRoots.join(',')}`,
Expand Down