Prevent rerender when a button callback returns false. #7197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danrha
requested review from
alexandrebodin,
alterx,
leonrodenburg and
theinterned
as code owners
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-danrha-next.storybook.now.sh |
danrha
changed the title
danrha
changed the title
CodeByAlex
approved these changes
Jun 25, 2019
wuweiweiwu
reviewed
Jun 26, 2019
Co-Authored-By: Wei-Wei Wu <hello@weiweiwu.me>
|
As this is something minor, is it possible to add this fix to the next 5.1.x release instead of waiting for 5.2? Thanks guys! |
shilman
added
the
patch:yes
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Jul 31, 2019
Prevent rerender when a button callback returns false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6675
What I did
I added a validation after firing knob click callback to prevent the story from re-rendering.
I'm not really sure why the default behavior is needed, but it's breaking my use case and according to #6675 someone else's.
I updated knobs documentation accordingly.