Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent rerender when a button callback returns false. #7197

Merged
merged 4 commits into from
Jul 7, 2019
Merged

Prevent rerender when a button callback returns false. #7197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8973b59
Prevent rerender when a button callback returns false.
danrha Jun 25, 2019
8ea2b06
Update knobs docs.
danrha Jun 25, 2019
e7cf084
Prevent rerender when a button callback returns false. (lint fix)
danrha Jun 26, 2019
d3d8357
Merge branch 'next' into pr/7197
shilman Jul 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions addons/knobs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,9 @@ const groupId = 'GROUP-ID1';
button(label, handler, groupId);
```

Button knobs cause the story to re-render after the handler fires, you can prevent
this by having the handler return false.

### withKnobs options

withKnobs also accepts two optional options as story parameters.
Expand Down
5 changes: 3 additions & 2 deletions addons/knobs/src/registerKnobs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,9 @@ function knobChanged(change) {

function knobClicked(clicked) {
const knobOptions = knobStore.get(clicked.name);
knobOptions.callback();
forceReRender();
if (knobOptions.callback() !== false) {
forceReRender();
}
}

function resetKnobs() {
Expand Down