Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-contexts: Remove peer dependencies #7675

Merged
merged 7 commits into from
Sep 22, 2019
Merged

Addon-contexts: Remove peer dependencies #7675

merged 7 commits into from
Sep 22, 2019

Conversation

leoyli
Copy link
Contributor

@leoyli leoyli commented Aug 4, 2019 •
edited by shilman
Loading

Issue: #7625

What I did

Remove peerDependencies since they install large unnecessary packages into your project.

How to test

N/A

@leoyli leoyli requested review from shilman and ndelangen August 4, 2019 17:18
@vercel
Copy link

vercel bot commented Aug 4, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-7625-addon-contexts-pkg.storybook.now.sh

@leoyli leoyli self-assigned this Aug 4, 2019
@leoyli leoyli added addon: contexts maintenance User-facing maintenance tasks labels Aug 4, 2019
@leoyli leoyli added this to the 5.1.x milestone Aug 4, 2019
shilman
shilman approved these changes Aug 5, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman changed the title suppress install warnings Addon-contexts: Remove peer dependencies Aug 5, 2019
@sjiep
Copy link

sjiep commented Aug 13, 2019

@leoyli any idea how to fix the checks?

@ndelangen ndelangen self-assigned this Aug 19, 2019
@ndelangen
Merge branch 'next' into 7625-addon-contexts-pkg
cfc4c3d 
# Conflicts:
#	addons/contexts/package.json
@vercel vercel bot temporarily deployed to staging August 30, 2019 21:27 Inactive
@ndelangen
Copy link
Member

Fixed the checks, I think

@ndelangen ndelangen modified the milestones: 5.1.x, 5.2.0 Aug 30, 2019
@leoyli
Copy link
Contributor Author

leoyli commented Aug 31, 2019

Maybe we can merge this now?!

@shilman shilman modified the milestones: 5.2.0, 5.3.0 Aug 31, 2019
@shilman
Copy link
Member

shilman commented Sep 1, 2019

@leoyli we'll get it first thing in 5.3

@shilman
Copy link
Member

shilman commented Sep 4, 2019

@leoyli Can you also do this for addon-centered: #7989

@shilman shilman added bug and removed maintenance User-facing maintenance tasks labels Sep 4, 2019
@shilman shilman mentioned this pull request Sep 4, 2019
Closed
@leoyli
Copy link
Contributor Author

leoyli commented Sep 5, 2019

@shilman, sure things, can you create an issue later for me and I will find a weekend to finish things up?! I'm really want to add more value back to the community but I need a bit momentum/pressure :p.

@leoyli leoyli mentioned this pull request Sep 22, 2019
Merged
@leoyli
Copy link
Contributor Author

leoyli commented Sep 22, 2019

@shilman, Is anything we want to do here to merge this PR? I guess you have a script to update package in the monorepo, so I think I should not do this by hand :p

@shilman
Copy link
Member

shilman commented Sep 22, 2019

thanks for the ping @leoyli - will merge once CI succeeds

@leoyli
Copy link
Contributor Author

leoyli commented Sep 22, 2019

All green! Let's merge it :D

@leoyli leoyli merged commit 6290707 into next Sep 22, 2019
@ndelangen ndelangen deleted the 7625-addon-contexts-pkg branch September 23, 2019 10:51
@shilman shilman mentioned this pull request Sep 24, 2019
Closed
@shilman shilman mentioned this pull request Feb 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@shilman shilman shilman approved these changes

Assignees

@ndelangen ndelangen

@leoyli leoyli

Labels
addon: contexts bug
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@leoyli @sjiep @ndelangen @shilman