Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REMOVE addon/center peerDependencies #8156

Merged
merged 3 commits into from
Sep 23, 2019
Merged

REMOVE addon/center peerDependencies #8156

merged 3 commits into from
Sep 23, 2019

Conversation

leoyli
Copy link
Contributor

@leoyli leoyli commented Sep 22, 2019 •
edited by shilman
Loading

Issue: #7989

What I did

  • Remove addon/center peerDependencies.

How to test

N/A

@leoyli leoyli requested review from shilman and ndelangen September 22, 2019 22:12
@leoyli leoyli requested a review from kazupon as a code owner September 22, 2019 22:12
@vercel
Copy link

vercel bot commented Sep 22, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-7989-addon-center-pkg.storybook.now.sh

@leoyli
Copy link
Contributor Author

leoyli commented Sep 22, 2019

Related to #7675.

@leoyli leoyli self-assigned this Sep 22, 2019
@leoyli leoyli added maintenance User-facing maintenance tasks and removed addon: centered labels Sep 22, 2019
@storybookjs storybookjs deleted a comment from github-actions bot Sep 22, 2019
@shilman shilman added addon: centered and removed maintenance User-facing maintenance tasks labels Sep 22, 2019
@leoyli
Copy link
Contributor Author

leoyli commented Sep 22, 2019

@shilman, do you know how to fix CD/CI here... ? I don't see the log from NOW... (it is fetching log endlessly)

@shilman shilman added this to the 5.3.0 milestone Sep 22, 2019
@shilman
Copy link
Member

shilman commented Sep 22, 2019

@leoyli bunch of linting errors! 😱

@leoyli
Copy link
Contributor Author

leoyli commented Sep 22, 2019 •
edited
Loading

@shilman, yes... I have noticed. Do you have any suggestion? I don't think that make sense for people to install the entire set of frameworks to use this addon. And I think we don't want peer or optional dependencies set up right?

/tmp/storybook/addons/centered/src/mithril.tsx
  2:1  error  'mithril' should be listed in the project's dependencies, not devDependencies  import/no-extraneous-dependencies

/tmp/storybook/addons/centered/src/preact.tsx
  2:1  error  'preact' should be listed in the project's dependencies, not devDependencies  import/no-extraneous-dependencies

/tmp/storybook/addons/centered/src/react.tsx
  1:1  error  'react' should be listed in the project's dependencies, not devDependencies  import/no-extraneous-dependencies

@shilman
Copy link
Member

shilman commented Sep 23, 2019

@leoyli what did you do for the other PR? can't we just use eslint-ignore to get rid of those errors?

@ndelangen ndelangen self-assigned this Sep 23, 2019
leoyli
leoyli commented Sep 23, 2019
View reviewed changes
Copy link
Contributor Author

@leoyli leoyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks! 👍

@ndelangen ndelangen merged commit 64741ea into next Sep 23, 2019
@ndelangen ndelangen deleted the 7989-addon-center-pkg branch September 23, 2019 12:57
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Sep 23, 2019
@Svish Svish mentioned this pull request Sep 26, 2019
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Oct 7, 2019
shilman pushed a commit that referenced this pull request Oct 7, 2019
@ndelangen @shilman
REMOVE addon/center peerDependencies (#8156)
def584e 
REMOVE addon/center peerDependencies

Co-authored-by: Leo Y. Li <leo.li@imagia.com>
Co-authored-by: Norbert de Langen <ndelangen@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman Awaiting requested review from shilman

@ndelangen ndelangen Awaiting requested review from ndelangen

@kazupon kazupon Awaiting requested review from kazupon

Assignees

@ndelangen ndelangen

@leoyli leoyli

Labels
addon: centered bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@leoyli @shilman @ndelangen