Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support auto title stories #35

Merged
merged 6 commits into from
Jan 31, 2022
Merged

Support auto title stories #35

merged 6 commits into from
Jan 31, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jan 28, 2022

Issue: #19

📦 Published PR as canary version: 0.0.2-canary.35.8a26a58.0

✨ Test out this PR locally via:

npm install @storybook/test-runner@0.0.2-canary.35.8a26a58.0
# or 
yarn add @storybook/test-runner@0.0.2-canary.35.8a26a58.0

Version

Published prerelease version: v0.0.2-next.4

Changelog

🐛 Bug Fix

⚠️ Pushed to next

📝 Documentation

  • docs(README): add section about jest #29 (@yannbf)

Authors: 2

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 looking great @yannbf

@shilman
Copy link
Member

shilman commented Jan 30, 2022

Except failing tests 🙈 😅

@yannbf
Copy link
Member Author

yannbf commented Jan 30, 2022

Except failing tests 🙈 😅

That's on purpose, I wanted to discuss with you if the approach was the final one, then I'd write the test

@yannbf yannbf changed the title WIP: support auto title stories Support auto title stories Jan 31, 2022
@yannbf yannbf force-pushed the feat/CH-1358-support-auto-title branch from c518ba7 to 8a26a58 Compare January 31, 2022 16:35
@yannbf yannbf merged commit b1db5ef into next Jan 31, 2022
@yannbf yannbf mentioned this pull request Jan 31, 2022
@yannbf yannbf deleted the feat/CH-1358-support-auto-title branch February 3, 2022 08:37
@yannbf yannbf mentioned this pull request Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants