-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI wrapper #41
Add CLI wrapper #41
Conversation
b107dd0
to
20840c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff. Minor stuff
@@ -1,10 +1,12 @@ | |||
import dedent from 'ts-dedent'; | |||
import path from 'path'; | |||
import * as coreCommon from '@storybook/core-common'; | |||
import * as cli from '../util/cli'; | |||
|
|||
import { transformPlaywright } from './transformPlaywright'; | |||
|
|||
jest.mock('@storybook/core-common'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need to mock this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because of the jest.spyOn(coreCommon, 'normalizeStories')
code below
20840c8
to
9b77c29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @yannbf !!
Issue: SB-20
What I did
This PR adds a CLI wrapper with the following commands:
It will retain test runner configs and pass the rest to jest-playwright. If users end up trying a flag that is not supported, they will get an error message with a link to open an issue on this repo:
📦 Published PR as canary version:
0.0.2-canary.41.9b77c29.0
✨ Test out this PR locally via:
npm install @storybook/test-runner@0.0.2-canary.41.9b77c29.0 # or yarn add @storybook/test-runner@0.0.2-canary.41.9b77c29.0
Version
Published prerelease version:
v0.0.2-next.6
Changelog
🐛 Bug Fix
next
📝 Documentation
Authors: 2