Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-common): fix missing env at StorybookConfig #21732

Merged
merged 5 commits into from
Mar 24, 2023

Conversation

zigang93
Copy link
Contributor

@zigang93 zigang93 commented Mar 22, 2023

Closes #21733

What I did

add missing env at StorybookConfig from error:

Type '{ stories: string[]; staticDirs: string[]; addons: string[]; core: { disableTelemetry: true; }; framework: { name: "@storybook/nextjs"; options: { strictMode: true; }; }; docs: { defaultName: string; autodocs: true; }; env: (config: any) => any; }' is not assignable to type 'StorybookConfig'.
  Object literal may only specify known properties, and 'env' does not exist in type 'StorybookConfig'.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@IanVS
Copy link
Member

IanVS commented Mar 22, 2023

Thanks @zigang93! It looks like I put it in the wrong spot in #21173. Would you mind also removing the type from BuilderOptions (where I had put it) now?

@IanVS IanVS requested review from kasperpeulen and IanVS March 22, 2023 15:23
@zigang93
Copy link
Contributor Author

Thanks @zigang93! It looks like I put it in the wrong spot in #21173. Would you mind also removing the type from BuilderOptions (where I had put it) now?

@IanVS Done

Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm the one who got it wrong before so take that with a grain of salt. 🙈

@kasperpeulen
Copy link
Contributor

Maybe @ndelangen can have another look?

@kasperpeulen kasperpeulen requested a review from ndelangen March 23, 2023 10:49
@ndelangen ndelangen merged commit 7d073d7 into storybookjs:next Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 'env' does not exist in type 'StorybookConfig'
4 participants