[addon-actions] Check result of getPropertyDescriptor for IE11 #2428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2428 +/- ##
==========================================
+ Coverage 16.64% 16.65% +0.01%
==========================================
Files 302 302
Lines 7769 7770 +1
Branches 786 776 -10
==========================================
+ Hits 1293 1294 +1
- Misses 5821 5879 +58
+ Partials 655 597 -58
Continue to review full report at Codecov.
|
Hypnosphi
approved these changes
Dec 4, 2017
Hypnosphi
reviewed
Dec 4, 2017
addons/actions/src/preview.js
Outdated
| // This condition is true in modern browsers that implement Function#name properly | ||
| const canConfigureName = Object.getOwnPropertyDescriptor(handler, 'name').configurable; | ||
| const canConfigureName = nameDescriptor && nameDescriptor.configurable; |
There was a problem hiding this comment.
We can also try !nameDescriptor || nameDescriptor.configurable. As far as I remember, IE11 had no problems with overriding function name
There was a problem hiding this comment.
Good call, I tested this suggestion in IE11 and it worked. Pushed a new commit, please have a look.
BernieSumption
added a commit
to newsuk/times-components
that referenced
this pull request
Dec 19, 2017
3.2.18 includes a fix for a bug that broke storybook in IE11: storybookjs/storybook#2428
craigbilner
pushed a commit
to newsuk/times-components
that referenced
this pull request
Dec 20, 2017
3.2.18 includes a fix for a bug that broke storybook in IE11: storybookjs/storybook#2428
4 tasks
BernieSumption
added a commit
to newsuk/times-components
that referenced
this pull request
Dec 22, 2017
3.2.18 includes a fix for a bug that broke storybook in IE11: storybookjs/storybook#2428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When using
action-addonsin IE11, it would throw "Unable to get property 'configurable' of undefined or null reference" because apparently IE returnsundefinedfromObject.getPropertyDescriptorwhen called on a function.What I did
Check result of
Object.getPropertyDescriptorbefore checking.configurable.How to test
Load storybook that uses
actionsin IE11 and verify that the iframe loads.Is this testable with jest or storyshots? No, this is IE-specific behaviour.
Does this need a new example in the kitchen sink apps? No
Does this need an update to the documentation? No