Switch to monorepo #749
Switch to monorepo #749
Conversation
Fix wrong npm package path
Provide storybook context to render
Add support for matching a story against a regex to run a story
Sorted stories by kind
Updated README to include sortStoriesByKind option
Provide mock Storybook Channel to Storybook Addons for compatibility with Storybook Addon Knobs
addons might init expecting the channel to exist.
|
@ndelangen Here are some notes from running it on a local project. TLDR; worked for me after a few minor bumps. Looks good!
|
This message is a known issue: https://github.com/storybooks/mono/issues/19 |
.eslintrc
Outdated
| "printWidth": 100, | ||
| "tabWidth": 2, | ||
| "bracketSpacing": true, | ||
| # "trailingComma": "es5", |
There was a problem hiding this comment.
Do we want to decide on this comma rule? I vote for all as a value
.eslintrc
Outdated
| }], | ||
| "quotes": ["warn", "single"], | ||
| "arrow-parens": ["warn", "as-needed"] | ||
| # "comma-dangle": ["warn", "always"] |
There was a problem hiding this comment.
Do we want to remove this line?
# Conflicts: # packages/react-storybook/src/server/config/defaults/webpack.config.js # packages/react-storybook/src/server/middleware.js
ndelangen
removed request for
tmeasday,
thani-sh,
apexskier,
heimdallrj,
majapw,
pahans,
benediktvaldez,
arbesfeld,
roonyh,
madushan1000,
xDae and
mthuret
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2df4be7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Issue: #742
What I did
Moved all the source for this package into a /packages/react-storybook
Merged in the monorepo master
Resolved mergeconflicts
How to test
install dependencies - this should bootstrap lerna.
run
npm run testin the root