Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: BC break introduced in 8.15.0 #6373

Closed
1 task done
phansys opened this issue Oct 16, 2024 · 3 comments · Fixed by #6375
Closed
1 task done

[Bug]: BC break introduced in 8.15.0 #6373

phansys opened this issue Oct 16, 2024 · 3 comments · Fixed by #6375

Comments

@phansys
Copy link

phansys commented Oct 16, 2024

Kind of Issue

Runtime - command-line tools

Tool or Library

cspell

Version

8.15.0

Supporting Library

No response

OS

Linux

OS Version

Alpine 3.20

Description

Until version 8.14.4, my implementation is working properly. Starting from 8.15.0, the execution of cspell lint fails with exit code 1.

The issue was probably introduced at #6167.

Steps to Reproduce

  1. cspell lint --config .cspell/cspell.yaml --debug --verbose
  2. cspell;
    Date: Wed, 16 Oct 2024 01:05:39 GMT
    Options:
        verbose:   Yes
        config:    .cspell/cspell.yaml
        exclude:   !config/secrets/**/*
                   node_modules/**
        files:     config/**/*.(php|yaml),doc/**/*.md,fixtures/**/*.yaml,migrations/**/*.php,src/**/*.(php|xml|yaml),templates/**/*.twig,tests/**/*.(php|yaml),translations/**/*.(xlf|xliff)
        wordsOnly: No
        unique:    No
    
    Config Files Found:
        /app/.cspell/cspell.yaml
    
    Exclusion Globs: 
        Glob: !config/secrets/**/* from command line
        Glob: node_modules/** from command line
    
    Usage: cspell lint [options] [globs...] [file://<path> ...] [stdin[://<path>]]
    ...

Expected Behavior

No errors, and exit code 0.

Additional Information

No response

cspell.json

No response

cspell.config.yaml

# .cspell/cspell.yaml

$schema: 'https://raw.githubusercontent.com/streetsidesoftware/cspell/main/cspell.schema.json'
version: '0.2'
language:
    - en
    - en-gb
globRoot: '../'
languageId:
    - 'php'
    - 'python'
    - 'sql'
files:
    - 'config/**/*.(php|yaml)'
    - '!config/secrets/'
    - 'doc/**/*.md'
    - 'fixtures/**/*.yaml'
    - 'migrations/**/*.php'
    - 'src/**/*.(php|xml|yaml)'
    - 'templates/**/*.twig'
    - 'tests/**/*.(php|yaml)'
    - 'translations/**/*.(xlf|xliff)'
useGitignore: true
gitignoreRoot: '../'
dictionaries:
    - 'project-terms'
    - 'stack-terms'
dictionaryDefinitions:
    -
        name: 'project-terms'
        path: './project-terms.txt'
    -
        name: 'stack-terms'
        path: './stack-terms.txt'
overrides:
    -
        language:
            - 'es'
            - 'en'
        filename: '*.es.xlf'
import:
    - '@cspell/dict-es-es/cspell-ext.json'

Example Repository

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Jason3S
Copy link
Collaborator

Jason3S commented Oct 16, 2024

@phansys,

Thank you for the report. I think this is the same as #6353
The issues seems to be the ! in the glob.

@Jason3S
Copy link
Collaborator

Jason3S commented Oct 16, 2024

Yes, it is related to #6167.

@phansys
Copy link
Author

phansys commented Oct 17, 2024

Closing as the issue is resolved at v8.15.3.

Thank you so much!

@phansys phansys closed this as completed Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants