feat: replace fast-glob with tinyglobby #6167

benmccann · 2024-08-26T15:44:25Z

This removes 15 dependencies

https://npmgraph.js.org/?q=fast-glob - 17 dependencies
https://npmgraph.js.org/?q=tinyglobby - 2 dependencies

ignore spelling Signed-off-by: Jason Dent <Jason3S@users.noreply.github.com>

Expand the snapshots for a few integration test repos to show all issues. This will help to see why the results in #6167 are failing.

Jason3S · 2024-08-27T08:04:14Z

@benmccann,

Thank you. I'll take a look.

Changing the glob library is a delicate task because each glob libraries has slightly different behavior and glob support.

A few of the integration tests are failing, but they do not show enough detail why. I'm guessing it is related to symbolic links. I am improved the reporting to give more insight.

Jason3S · 2024-08-27T08:19:18Z

Thank you for your contribution.

I would also like to thank you for your work on Svelte. It is a great framework.

This removes 15 dependencies

https://npmgraph.js.org/?q=fast-glob - 17 dependencies

https://npmgraph.js.org/?q=tinyglobby - 2 dependencies

I'm all for dropping dependencies. Just so I am clear, what is the motivation for picking tinyglobby? It seems to be a brand new package with little history.

I don't understand the CI error that says tinyglobby isn't a word. How do I fix that?

There are a few ways:

Add it to the dictionary file: cspell-dict.txt.
Add a CSpell directive to the file. (this is what I did to silence the warning)
```
// cspell:ignore tinyglobby
```

Jason3S · 2024-08-27T08:40:44Z

After extending the integration test reporting, it is clear that the issue is with symbolic links. They are causing the same file to be reported on multiple times.

benmccann · 2024-08-27T21:00:01Z

Oops. I'll close this for now due to the test failure and reopen when I've got it working. Thanks for the kind words, btw!

The reason I chose tinyglobby was because it was built to be a drop-in replacement for globby and because I'm not really aware of any others that are just as small and have the same functionality.

A bunch of widely used projects like nuxt, unocss, ni, tsup, eslint-react, vite-plugin-pwa, pkg.pr.new, and publint have switched to tinyglobby, so while it's a relatively new library it has gotten the tires kicked pretty well. picomatch is used under the covers to do the actual globbing

Jason3S · 2024-08-28T09:47:37Z

I see the tinyglobby author opened few issues on fdir related to sym links.

SuperchupuDev · 2024-08-28T11:22:19Z

I see the tinyglobby author opened few issues on fdir related to sym links.

Hi! tinyglobby author here. Just FYI, the issues I opened related to symlinks are only applicable when symlinks are resolved, which isn't the case here. I just opened thecodrr/fdir#115 though which should allow tinyglobby to exclude symlinks (until the followSymbolicLinks option gets added)

SuperchupuDev · 2024-09-30T15:07:19Z

FYI proper support for symlinks / excluding symlinks was implemented in today's tinyglobby release, 0.2.7, which should solve the issues reported here

benmccann · 2024-09-30T18:06:27Z

I've updated this PR to use the latest tinyglobby and all tests are passing now

packages/cspell/src/app/util/glob.ts

ghiscoding · 2024-10-01T14:03:21Z

side note, it seems that a mem leak was found and followSymbolicLinks was reverted in v0.2.9,
see SuperchupuDev/tinyglobby#54

SuperchupuDev · 2024-10-01T14:04:56Z

Only followSymbolicLinks: true was reverted, I intentionally didn't revert disabling them so that this PR keeps working

Jason3S · 2024-10-01T17:36:55Z

Thank you.

github-actions · 2024-10-01T17:45:23Z

Performance Report

Daily Performance

xychart-beta
    title Files Per Second by Day
    y-axis Files per Second
    x-axis Date [Sep-2, Sep-6, Sep-9, Sep-10, Sep-13, Sep-16, Sep-17, Sep-18, Sep-22, Sep-23, Sep-29, Sep-30, Oct-1]
    bar [175.68, 178.38, 175.73, 175.70, 175.56, 170.99, 174.42, 176.15, 171.49, 170.60, 174.68, 172.58, 170.62]
    line [122.42, 114.54, 119.33, 121.78, 117.69, 120.09, 120.05, 120.31, 117.43, 109.01, 117.33, 114.51, 112.29]
    line [76.26, 75.33, 0.00, 76.18, 75.30, 72.34, 73.59, 69.54, 71.59, 70.97, 67.35, 0.00, 70.29]
    line [451.36, 445.82, 0.00, 442.79, 448.98, 444.77, 437.29, 443.15, 426.39, 420.42, 425.42, 0.00, 405.76]
    line [232.38, 230.54, 0.00, 229.61, 230.62, 234.72, 234.92, 228.04, 217.32, 205.66, 217.69, 0.00, 214.10]
    line [249.29, 224.39, 0.00, 241.04, 239.64, 234.60, 238.64, 244.36, 234.31, 230.98, 235.16, 0.00, 230.90]
    line [8.92, 9.30, 0.00, 9.85, 9.67, 9.68, 9.92, 9.37, 9.23, 9.26, 8.29, 0.00, 8.90]
    line [40.72, 39.85, 0.00, 39.94, 41.26, 40.08, 36.34, 39.18, 37.74, 37.18, 36.89, 0.00, 37.27]
    line [134.10, 133.16, 133.12, 133.37, 136.08, 131.30, 132.64, 136.81, 125.88, 123.97, 123.26, 124.35, 122.36]
    line [198.37, 193.18, 205.21, 202.42, 187.59, 200.94, 202.64, 174.86, 188.42, 184.98, 195.97, 189.74, 185.35]
    line [17.23, 19.98, 0.00, 20.38, 20.10, 19.75, 19.58, 19.44, 18.99, 18.71, 18.44, 0.00, 13.99]
    line [82.19, 79.19, 0.00, 81.30, 83.34, 82.19, 82.78, 80.29, 80.65, 77.47, 76.93, 0.00, 78.07]
    line [36.83, 35.85, 0.00, 37.06, 36.42, 35.98, 35.70, 34.54, 34.55, 33.11, 34.81, 0.00, 35.17]
    line [379.20, 373.63, 372.65, 376.36, 368.52, 365.71, 377.56, 376.77, 361.09, 354.59, 368.19, 364.07, 344.36]
    line [98.44, 103.61, 0.00, 95.82, 91.96, 97.25, 88.47, 97.89, 91.06, 89.08, 89.06, 0.00, 90.96]
    line [168.11, 162.00, 0.00, 166.81, 166.56, 165.69, 164.68, 158.25, 149.51, 158.09, 156.96, 161.98, 156.93]
    line [140.40, 143.33, 143.38, 143.55, 140.59, 138.57, 140.62, 141.72, 135.93, 132.42, 137.90, 131.39, 125.40]
    line [251.96, 258.89, 257.30, 255.86, 259.52, 256.30, 250.62, 253.31, 250.10, 236.21, 245.48, 0.00, 255.93]
    line [232.84, 224.81, 0.00, 227.34, 228.09, 230.87, 227.16, 231.88, 223.22, 214.31, 216.24, 0.00, 216.91]
    line [143.31, 137.86, 0.00, 143.10, 144.41, 139.70, 143.74, 112.39, 139.33, 141.10, 137.72, 0.00, 139.61]
    line [53.54, 52.52, 0.00, 52.32, 54.12, 51.77, 53.09, 51.40, 50.85, 49.44, 50.07, 0.00, 50.63]
    line [43.29, 42.33, 0.00, 41.15, 42.24, 41.01, 42.53, 38.05, 39.43, 38.14, 38.94, 0.00, 39.96]
    line [128.81, 149.88, 0.00, 151.49, 151.06, 156.36, 155.63, 151.63, 151.94, 152.50, 152.06, 143.32, 149.19]
    line [203.78, 213.00, 214.26, 206.28, 205.22, 203.09, 207.23, 202.88, 201.82, 207.79, 207.90, 201.29, 209.19]
    line [278.30, 269.85, 262.88, 274.40, 281.31, 272.54, 275.91, 275.97, 256.03, 258.54, 258.01, 259.58, 248.67]
    line [174.42, 171.06, 0.00, 173.10, 169.76, 175.73, 176.36, 175.75, 159.14, 168.41, 169.31, 0.00, 170.99]
    line [71.07, 70.80, 70.10, 70.83, 70.27, 68.51, 69.01, 65.91, 63.15, 63.41, 65.35, 0.00, 69.02]
    line [98.03, 113.59, 117.23, 110.00, 114.04, 109.51, 113.51, 116.46, 104.81, 102.79, 108.89, 103.13, 103.52]
    line [128.16, 146.70, 0.00, 151.25, 142.95, 141.14, 143.95, 140.92, 145.29, 140.59, 139.11, 138.01, 142.88]
    line [93.42, 92.85, 96.99, 93.46, 97.52, 91.70, 93.14, 88.50, 84.12, 92.41, 91.76, 86.84, 88.64]
    line [87.46, 87.14, 81.35, 83.34, 83.78, 82.79, 83.96, 85.57, 82.01, 81.81, 82.67, 0.00, 83.49]
    line [221.13, 223.08, 217.30, 217.60, 210.80, 216.66, 208.33, 215.69, 211.15, 207.60, 206.93, 205.06, 202.44]
    line [369.19, 372.46, 362.58, 366.57, 385.92, 371.23, 373.66, 361.57, 355.78, 361.81, 351.17, 345.43, 358.65]
    line [182.17, 179.93, 181.55, 184.12, 189.95, 185.74, 153.97, 189.99, 184.11, 172.95, 176.46, 163.78, 167.39]
    line [31.96, 32.39, 0.00, 33.27, 33.48, 33.18, 30.65, 34.02, 29.87, 31.63, 30.68, 0.00, 31.32]
    line [392.41, 395.48, 385.49, 402.68, 388.38, 390.24, 382.26, 399.81, 383.04, 391.20, 384.82, 375.34, 397.41]
    line [230.93, 227.50, 233.38, 223.69, 216.25, 228.77, 208.66, 221.89, 226.09, 216.90, 207.46, 223.39, 229.16]
    line [119.32, 127.89, 123.29, 124.49, 129.64, 121.66, 124.08, 126.72, 119.08, 118.45, 114.87, 112.49, 118.05]
    line [250.46, 249.77, 240.66, 262.89, 257.78, 257.49, 249.43, 247.25, 248.88, 251.75, 245.20, 245.06, 224.85]
    line [89.68, 92.88, 88.59, 86.05, 89.85, 89.86, 94.27, 91.54, 90.45, 90.71, 92.55, 89.39, 93.96]
    line [173.82, 183.91, 169.15, 181.18, 183.51, 175.60, 176.44, 174.39, 169.65, 170.91, 168.95, 166.28, 173.86]
    line [263.57, 250.38, 244.75, 250.69, 253.77, 247.48, 255.65, 251.83, 237.98, 246.89, 242.54, 243.09, 224.03]
    line [155.92, 153.19, 0.00, 155.03, 154.46, 150.27, 151.44, 153.53, 138.23, 146.78, 144.54, 144.66, 146.29]
    line [56.79, 55.22, 55.40, 55.63, 54.54, 52.86, 55.21, 52.35, 50.94, 48.45, 51.30, 50.59, 50.58]
    line [30.96, 30.04, 0.00, 31.22, 29.93, 31.17, 32.23, 31.60, 29.23, 29.18, 25.62, 0.00, 29.72]
    line [170.71, 168.98, 170.63, 166.15, 168.68, 161.23, 172.09, 168.48, 164.20, 163.31, 169.03, 172.29, 155.24]
    line [262.12, 249.11, 258.37, 255.88, 255.75, 261.30, 254.48, 241.79, 249.14, 250.28, 251.57, 258.18, 242.58]
    line [133.06, 133.03, 112.77, 129.44, 131.63, 130.97, 130.22, 113.06, 109.25, 122.56, 121.09, 0.00, 125.59]
    line [161.33, 168.54, 172.61, 166.17, 170.88, 163.08, 171.82, 163.97, 154.58, 167.67, 161.60, 161.14, 157.44]
    line [143.06, 151.08, 140.90, 145.94, 143.19, 137.67, 143.95, 148.30, 144.49, 142.14, 152.04, 143.84, 146.29]

Time to Process Files

Repository	Elapsed	Min/Avg/Max	SD	SD Graph
_{AdaDoom3/AdaDoom3}	2.93	2.7 / 2.9 / 3.1	0.10	`┣━━┻━━╋●━┻━━┫`
_{alexiosc/megistos}	7.47	6.6 / 7.2 / 7.6	0.25	`┣━━┻━━╋━━●━━┫`
_{apollographql/apollo-server}	2.23	2.0 / 2.1 / 2.3	0.06	`┣━┻━━╋━━┻━●`
_{aspnetboilerplate/aspnetboilerplate}	10.70	10.5 / 10.8 / 11.6	0.28	`┣━━┻━●╋━━┻━━┫`
_{aws-amplify/docs}	12.60	10.7 / 11.2 / 11.8	0.33	`┣━┻━━╋━━┻━┫ ●`
_{Azure/azure-rest-api-specs}	13.95	12.9 / 13.8 / 14.8	0.52	`┣━━━┻━━╋●━┻━━━┫`
_{bitjson/typescript-starter}	0.64	0.6 / 0.6 / 0.7	0.03	`┣━━┻━╋●┻━━┫`
_{caddyserver/caddy}	3.11	2.8 / 3.0 / 3.5	0.17	`┣━━┻━━╋━●┻━━┫`
_{canada-ca/open-source-logiciel-libre}	0.79	0.7 / 0.7 / 0.8	0.04	`┣━┻━━╋━━●━┫`
_chef/chef	5.24	5.1 / 5.4 / 6.0	0.23	`┣━━┻●━╋━━┻━━┫`
_{dart-lang/sdk}	62.63	55.6 / 58.1 / 70.4	3.12	`┣━━━┻━━━╋━━━┻━●━┫`
_{django/django}	13.35	13.0 / 13.6 / 14.3	0.33	`┣━━┻●━╋━━┻━━┫`
_{eslint/eslint}	9.96	8.9 / 9.3 / 9.8	0.28	`┣━━┻━━╋━━┻━━┫●`
_{exonum/exonum}	3.02	2.9 / 3.0 / 3.7	0.20	`┣━━┻━━●━━┻━━┫`
_{flutter/samples}	17.03	13.7 / 14.6 / 18.4	1.23	`┣━━━┻━━╋━━┻━━━●`
_{gitbucket/gitbucket}	3.28	2.8 / 3.0 / 3.1	0.09	`┣━━┻━━╋━━┻━━┫ ●`
_{googleapis/google-cloud-cpp}	134.62	129.5 / 136.7 / 145.8	3.92	`┣━━━┻━●━╋━━━┻━━━┫`
_{graphql/express-graphql}	0.70	0.6 / 0.7 / 0.8	0.04	`┣━┻━━╋━●┻━┫`
_{graphql/graphql-js}	2.12	1.9 / 2.1 / 2.2	0.08	`┣━┻━━╋━●┻━┫`
_{graphql/graphql-relay-js}	0.70	0.6 / 0.7 / 0.7	0.03	`┣━┻━━╋●━┻━┫`
_{graphql/graphql-spec}	1.07	0.7 / 0.8 / 0.9	0.04	`┣━┻╋┻━┫ ●`
_{iluwatar/java-design-patterns}	10.75	10.3 / 10.8 / 12.5	0.50	`┣━━┻━━●━━┻━━┫`
_{ktaranov/sqlserver-kit}	5.86	5.6 / 5.9 / 6.1	0.14	`┣━━┻━━●━━┻━━┫`
_{liriliri/licia}	3.50	3.1 / 3.2 / 3.4	0.08	`┣━━┻━━╋━━┻━━┫ ●`
_{MartinThoma/LaTeX-examples}	6.49	5.9 / 6.2 / 6.6	0.19	`┣━━┻━━╋━━┻●━┫`
_mdx-js/mdx	1.58	1.4 / 1.5 / 1.8	0.09	`┣━┻━━╋━●┻━┫`
_{microsoft/TypeScript-Website}	5.08	4.7 / 5.0 / 5.9	0.24	`┣━━┻━━╋●━┻━━┫`
_{MicrosoftDocs/PowerShell-Docs}	22.80	20.6 / 22.0 / 23.9	0.96	`┣━━━┻━━╋━━●━━━┫`
_{neovim/nvim-lspconfig}	2.90	2.6 / 2.7 / 2.9	0.12	`┣━━┻━━╋━━┻━●┫`
_{pagekit/pagekit}	3.21	3.0 / 3.1 / 3.3	0.09	`┣━━┻━━╋━━●━━┫`
_php/php-src	23.53	23.5 / 24.5 / 26.1	0.67	`┣━●━┻━━╋━━┻━━━┫`
_{plasticrake/tplink-smarthome-api}	0.88	0.8 / 0.8 / 0.9	0.03	`┣━┻━━╋━●┻━┫`
_{prettier/prettier}	6.38	5.7 / 5.9 / 6.2	0.14	`┣━━┻━━╋━━┻━━┫ ●`
_{pycontribs/jira}	1.16	1.1 / 1.2 / 1.3	0.06	`┣━┻━●╋━━┻━┫`
_{RustPython/RustPython}	4.35	4.0 / 4.4 / 6.1	0.43	`┣━━┻━━●━━┻━━┫`
_{shoelace-style/shoelace}	2.36	2.1 / 2.2 / 2.5	0.11	`┣━━┻━━╋━━●━━┫`
_{SoftwareBrothers/admin-bro}	2.06	1.8 / 1.9 / 2.1	0.08	`┣━┻━━╋━━┻●┫`
_{sveltejs/svelte}	18.76	18.2 / 18.9 / 20.3	0.52	`┣━━━┻━●╋━━┻━━━┫`
_{TheAlgorithms/Python}	5.44	4.7 / 5.0 / 5.3	0.17	`┣━━┻━━╋━━┻━━┫ ●`
_{twbs/bootstrap}	1.16	1.0 / 1.1 / 1.4	0.08	`┣━┻━━╋━●┻━┫`
_{typescript-cheatsheets/react}	1.05	1.0 / 1.0 / 1.1	0.03	`┣━┻━━╋━●┻━┫`
_{typescript-eslint/typescript-eslint}	3.48	3.2 / 3.4 / 3.7	0.13	`┣━━┻━━╋━●┻━━┫`
_{vitest-dev/vitest}	7.42	6.6 / 7.0 / 7.4	0.21	`┣━━┻━━╋━━┻━━┫●`
_{w3c/aria-practices}	2.75	2.5 / 2.7 / 3.0	0.12	`┣━━┻━━╋━●┻━━┫`
_{w3c/specberus}	1.59	1.5 / 1.6 / 2.1	0.15	`┣━━┻━━●━━┻━━┫`
_{webdeveric/webpack-assets-manifest}	0.64	0.6 / 0.6 / 0.7	0.04	`┣━┻━━╋●━┻━┫`
_{webpack/webpack}	4.85	4.1 / 4.4 / 4.7	0.15	`┣━━┻━━╋━━┻━━┫ ●`
_{wireapp/wire-desktop}	0.85	0.7 / 0.8 / 0.9	0.04	`┣━┻━━╋━━●━┫`
_{wireapp/wire-webapp}	7.79	7.0 / 7.4 / 8.0	0.30	`┣━━┻━━╋━━┻●━┫`

Note:

Elapsed time is in seconds.

Files per Second over Time

Repository	Files	Sec	Fps	Rel	Trend Fps	N
_{AdaDoom3/AdaDoom3}	103	2.93	35.17	-1.32%	`▇▆▇█▇▇▆▇▅▇▅▅▅▄▅▆`	15
_{alexiosc/megistos}	583	7.47	78.07	-3.74%	`▆▅▆▅▆▆▇▅▄█▅▅▅▄▄▄`	15
_{apollographql/apollo-server}	250	2.23	112.29	-5.18%	`█▆▇█▇▇▆█▇▇▇▇▇▆▇▄▆▆▅`	18
_{aspnetboilerplate/aspnetboilerplate}	2739	10.70	255.93	1.11%	`▆▇██▇████▇█▆█▇▆▇▄▆▇`	18
_{aws-amplify/docs}	2832	12.60	224.85	-10.83%	`▄█▆▄██▇▇▆▇█▅▇▆▅▆▆▅▅▂`	19
_{Azure/azure-rest-api-specs}	2426	13.95	173.86	-0.79%	`▇▅█▅█▆▇█▇▅▆▆▆▆▆▄▅▅▄▆`	19
_{bitjson/typescript-starter}	20	0.64	31.32	-2.46%	`▆▇▇████▇▅▅█▃▅▆▅▅`	15
_{caddyserver/caddy}	276	3.11	88.64	-3.64%	`█▆▇█▆███▇▇▄▇▆▅▃▆▆▆▅▅`	19
_{canada-ca/open-source-logiciel-libre}	7	0.79	8.90	-5.83%	`▅▆██▇▇▇▇██▆▆▅▆▃▅`	15
_chef/chef	1201	5.24	229.16	2.98%	`▇█▇█▆▇▅▅▆▇█▃▅▆▇▇▆▄▆▇`	19
_{dart-lang/sdk}	9723	62.63	155.24	-7.25%	`█▇▇█▇▇█▇██▃▇█▇▆▇▆▇█▅`	19
_{django/django}	2792	13.35	209.19	1.78%	`▇▅██▇▆▇▆▆▇▄█▆▆▆▅▇▇▆▇`	19
_{eslint/eslint}	2016	9.96	202.44	-5.35%	`█▇█▇▆█▅▇▇▆█▆▄▇▅▆▅▅▅▄`	19
_{exonum/exonum}	421	3.02	139.61	0.06%	`▇▇▇▇█▇█▆█▇▂▇▇▇▇▇`	15
_{flutter/samples}	2850	17.03	167.39	-6.75%	`█▇▇▇█▇███▇█▅▂█▇█▆▆▅▅`	19
_{gitbucket/gitbucket}	411	3.28	125.40	-10.02%	`▇▇████▇▇▇▅▇▇▇▇▅▇▅▆▄▃`	19
_{googleapis/google-cloud-cpp}	19694	134.62	146.29	1.72%	`▆▆█▅▆▇▆▆▅▄▄▆▇▇▆▆▆█▆▇`	19
_{graphql/express-graphql}	26	0.70	37.27	-4.36%	`█▇▆███▇█▇▃▇▆▅▅▅▅`	15
_{graphql/graphql-js}	333	2.12	156.93	-3.26%	`▇▆▇▇▅█▇▇▆▇▆▅▃▃▅▅▆▅`	17
_{graphql/graphql-relay-js}	28	0.70	39.96	-2.28%	`█▇█▄▆█▇▅█▆▄▅▅▄▄▅`	15
_{graphql/graphql-spec}	15	1.07	13.99	-28.00%	`▃▇██▇█▇▇█▆▆▆▆▅▅`	15
_{iluwatar/java-design-patterns}	1838	10.75	170.99	-0.09%	`▇▇▇▇▇▆█▇███▇▃▆▇▇`	15
_{ktaranov/sqlserver-kit}	489	5.86	83.49	-0.14%	`██▅▆▆▆▇▆▆▅▇▇▅▆▅▆▆`	16
_{liriliri/licia}	1421	3.50	405.76	-7.59%	`█▇▇▇█▇▇▇▇▆▇▅▆▅▅▃`	15
_{MartinThoma/LaTeX-examples}	1407	6.49	216.91	-4.12%	`▇▆▆▇▆▇▇▇█▄▇▆▅▄▄▄`	15
_mdx-js/mdx	144	1.58	90.96	-3.53%	`▇▇█▆▆▄▆▆▇▆▆▃▇▅▅▄▄▅`	17
_{microsoft/TypeScript-Website}	758	5.08	149.19	-1.22%	`▃▆▇▆▆▇▇██▇█▇▇▆▇▇▅▆`	17
_{MicrosoftDocs/PowerShell-Docs}	2692	22.80	118.05	-3.40%	`▇▃▇▆▇▆██▆▆▆▆▇▇▆▅▅▄▃▅`	19
_{neovim/nvim-lspconfig}	355	2.90	122.36	-6.74%	`▇▇▇▇▇▇██▇█▄▇▆█▆▄▄▄▄▄`	19
_{pagekit/pagekit}	741	3.21	230.90	-2.73%	`█▄█▆▇▆▅▇▆▇▇▆▆▅▆▅`	15
_php/php-src	2211	23.53	93.96	4.05%	`▅▇█▆▄▅▅▇▇▆▆██▇▆▇▇▇▆█`	19
_{plasticrake/tplink-smarthome-api}	62	0.88	70.29	-3.92%	`▇▇▇██▆▇▅▆▇▄▅▆▅▃▅`	15
_{prettier/prettier}	2196	6.38	344.36	-7.02%	`██▇▇▇▇▇▆▅▇█▇▇▆▅▅▆▆▄`	18
_{pycontribs/jira}	80	1.16	69.02	1.03%	`███▇█▇█▇█▆▆█▆▆▃▅▅▇`	17
_{RustPython/RustPython}	621	4.35	142.88	0.78%	`█▂▇███▆▆█▆▇▇▇▇▇▆▆▆▇`	18
_{shoelace-style/shoelace}	437	2.36	185.35	-4.87%	`▇▆█▇█▇▃█▇▇▇█▃▆▅▅▆▅▅`	18
_{SoftwareBrothers/admin-bro}	441	2.06	214.10	-5.92%	`▇▇▇▇▇█▆▇███▇▅▅▃▅▅`	16
_{sveltejs/svelte}	7455	18.76	397.41	2.03%	`▇▇▇▆██▇▆▇▇▆█▄█▅▇▇▆▅▇`	19
_{TheAlgorithms/Python}	1352	5.44	248.67	-7.98%	`█▆▆▅▆▇▇█▆▇▆▇▇▇▄▄▄▄▅▃`	19
_{twbs/bootstrap}	120	1.16	103.52	-5.05%	`▂▆▇█▇▆▇█▇▇▅█▇█▆▅▅▆▅▅`	19
_{typescript-cheatsheets/react}	53	1.05	50.63	-2.80%	`▇▆▇▅▇█▅▇▆▇▆▅▅▄▅▅`	15
_{typescript-eslint/typescript-eslint}	1247	3.48	358.65	-2.25%	`▆▆▆▅▅▇▇███▃▆▇▅▅▅▅▄▄▅`	19
_{vitest-dev/vitest}	1801	7.42	242.58	-4.93%	`▇█▅▇█▄▇▅▇▆█▆▆▄▅▅▅▆▇▄`	19
_{w3c/aria-practices}	403	2.75	146.29	-2.60%	`▇█▇█▇▇█▇▅▇█▆▇▃▅▆▅▅▆`	18
_{w3c/specberus}	200	1.59	125.59	-0.09%	`█▇█▅▇▇▇█▇█▇█▆▅▂▆▆▆▇`	18
_{webdeveric/webpack-assets-manifest}	19	0.64	29.72	-2.02%	`▇▆▇▇▄█▇▇██▇▆▅▅▃▆`	15
_{webpack/webpack}	1086	4.85	224.03	-10.30%	`██▆▅▆▆▇▆▇▆▄▇▇▆▃▆▆▅▅▃`	19
_{wireapp/wire-desktop}	43	0.85	50.58	-5.60%	`█▇▇▇▇▇▆▇▃▇▆▇▇▅▅▄▃▅▄▄`	19
_{wireapp/wire-webapp}	1227	7.79	157.44	-4.56%	`▇▄▇█▅▇█▇▅▆▆█▇▆▄▄▇▅▅▅`	19

Data Throughput

Repository	Files	Sec	Kps	Rel	Trend Kps	N
_{AdaDoom3/AdaDoom3}	103	2.93	747.41	-1.32%	`▇▆▇█▇▇▆▇▅▇▅▅▅▄▅▆`	15
_{alexiosc/megistos}	583	7.47	613.47	-3.74%	`▆▅▆▅▆▆▇▅▄█▅▅▅▄▄▄`	15
_{apollographql/apollo-server}	250	2.23	889.82	-5.18%	`█▆▇█▇▇▆█▇▇▇▇▇▆▇▄▆▆▅`	18
_{aspnetboilerplate/aspnetboilerplate}	2739	10.70	595.02	-0.77%	`▆▇██▇████▇█▆█▇▆▇▄▅▇`	18
_{aws-amplify/docs}	2832	12.60	750.61	-10.42%	`▄█▆▄██▇▇▆▇█▅▇▆▅▆▆▅▅▂`	19
_{Azure/azure-rest-api-specs}	2426	13.95	496.42	-0.56%	`▇▅█▅█▆▇█▇▅▆▇▆▆▆▄▅▅▄▆`	19
_{bitjson/typescript-starter}	20	0.64	125.26	-2.46%	`▆▇▇████▇▅▅█▃▅▆▅▅`	15
_{caddyserver/caddy}	276	3.11	721.64	-3.40%	`█▅▇█▆███▇▇▄▇▆▆▃▆▇▆▅▆`	19
_{canada-ca/open-source-logiciel-libre}	7	0.79	73.78	-5.83%	`▅▆██▇▇▇▇██▆▆▅▆▃▅`	15
_chef/chef	1201	5.24	1051.55	2.63%	`▇█▇█▆▇▆▆▆▇█▃▅▆▇▇▆▄▆▇`	19
_{dart-lang/sdk}	9723	62.63	1122.60	-7.49%	`█▇▇█▇▇█▇██▃▇█▇▆▇▆▇█▅`	19
_{django/django}	2792	13.35	1280.24	1.95%	`▇▅██▇▆▇▆▆▇▄█▆▆▆▅▇▇▆▇`	19
_{eslint/eslint}	2016	9.96	1652.77	-5.48%	`█▇█▇▇█▅▇▇▇█▆▅▇▆▇▅▅▅▄`	19
_{exonum/exonum}	421	3.02	1335.41	0.06%	`▇▇▇▇█▇█▆█▇▂▇▇▇▇▇`	15
_{flutter/samples}	2850	17.03	1298.16	-3.77%	`█▇▇▇█▇███▇█▅▂█▇█▆▆▆▆`	19
_{gitbucket/gitbucket}	411	3.28	566.60	-10.02%	`▇▇████▇▇▇▅▇▇▇▇▅▇▅▆▄▃`	19
_{googleapis/google-cloud-cpp}	19694	134.62	1044.24	1.74%	`▆▆█▅▆▇▆▆▅▄▄▆▆▇▆▆▆█▆▇`	19
_{graphql/express-graphql}	26	0.70	170.58	-4.36%	`█▇▆███▇█▇▃▇▆▅▅▅▅`	15
_{graphql/graphql-js}	333	2.12	894.90	-3.07%	`▇▆▇▇▅█▇▇▆▇▆▅▃▃▅▅▆▅`	17
_{graphql/graphql-relay-js}	28	0.70	157.00	-2.28%	`█▇█▄▆█▇▅█▆▄▅▅▄▄▅`	15
_{graphql/graphql-spec}	15	1.07	513.83	-28.00%	`▃▇██▇█▇▇█▆▆▆▆▅▅`	15
_{iluwatar/java-design-patterns}	1838	10.75	526.19	-0.09%	`▇▇▇▇▇▆█▇███▇▃▆▇▇`	15
_{ktaranov/sqlserver-kit}	489	5.86	1262.95	-0.14%	`██▅▆▆▆▇▆▆▅▇▇▅▆▅▆▆`	16
_{liriliri/licia}	1421	3.50	478.29	-7.50%	`█▇▇▇█▇▇▇▇▆▇▅▆▅▅▃`	15
_{MartinThoma/LaTeX-examples}	1407	6.49	448.31	-4.12%	`▇▆▆▇▆▇▇▇█▄▇▆▅▄▄▄`	15
_mdx-js/mdx	144	1.58	416.89	-3.28%	`▇▇█▆▆▄▆▆▇▆▆▃▇▅▅▄▄▅`	17
_{microsoft/TypeScript-Website}	758	5.08	1020.89	-1.31%	`▃▆▇▆▆▇▇██▇█▇▇▆▇▇▅▆`	17
_{MicrosoftDocs/PowerShell-Docs}	2692	22.80	1206.18	-3.45%	`▇▃▇▆▇▆██▆▆▆▆▇▇▆▅▅▄▃▅`	19
_{neovim/nvim-lspconfig}	355	2.90	320.19	-7.19%	`█▇▇▇█▇██▇█▄▇▆█▆▄▄▄▄▄`	19
_{pagekit/pagekit}	741	3.21	481.42	-2.73%	`█▄█▆▇▆▅▇▆▇▇▆▆▅▆▅`	15
_php/php-src	2211	23.53	1371.84	4.12%	`▅▇█▆▄▅▅▇▇▆▆██▇▆▇▇▇▆█`	19
_{plasticrake/tplink-smarthome-api}	62	0.88	379.81	-3.92%	`▇▇▇██▆▇▅▆▇▄▅▆▅▃▅`	15
_{prettier/prettier}	2196	6.38	480.16	-6.98%	`██▇▇▇▇▇▆▅▇█▇▇▆▅▅▆▆▄`	18
_{pycontribs/jira}	80	1.16	475.34	1.02%	`███▇█▇█▇█▆▆█▆▆▃▅▅▇`	17
_{RustPython/RustPython}	621	4.35	1051.67	1.06%	`█▂▇███▆▆█▆▇▇▇▇▇▇▆▆▇`	18
_{shoelace-style/shoelace}	437	2.36	880.52	-4.27%	`▇▆█▇▇▇▃█▇▇▇█▃▆▅▅▇▆▅`	18
_{SoftwareBrothers/admin-bro}	441	2.06	471.88	-6.02%	`▇▇▇▇▇█▆▇███▇▅▅▃▅▅`	16
_{sveltejs/svelte}	7455	18.76	286.37	1.75%	`▇▇▇▆██▇▆▇▇▆█▄█▅▇▇▆▅▇`	19
_{TheAlgorithms/Python}	1352	5.44	628.49	-8.26%	`█▇▆▅▆▇▇█▆▇▆▇▇▇▄▄▄▄▄▃`	19
_{twbs/bootstrap}	120	1.16	828.98	-5.05%	`▂▆▇█▇▆▇█▇▇▅█▇█▆▅▅▆▅▅`	19
_{typescript-cheatsheets/react}	53	1.05	369.67	-2.80%	`▇▆▇▅▇█▅▇▆▇▆▅▅▄▅▅`	15
_{typescript-eslint/typescript-eslint}	1247	3.48	1668.99	-1.60%	`▆▆▆▅▅▇▇███▃▆▇▅▅▅▅▅▄▅`	19
_{vitest-dev/vitest}	1801	7.42	494.19	-5.74%	`▇█▅▇█▄▇▅▇▆█▆▆▄▅▅▅▅▆▄`	19
_{w3c/aria-practices}	403	2.75	1363.84	-2.40%	`▇█▇█▇▇▇▇▅▇█▆▇▃▅▆▅▅▆`	18
_{w3c/specberus}	200	1.59	400.62	-0.09%	`█▇█▅▇▇▇█▇█▇█▆▅▂▆▆▆▇`	18
_{webdeveric/webpack-assets-manifest}	19	0.64	159.54	-2.02%	`▇▆▇▇▄█▇▇██▇▆▅▅▃▆`	15
_{webpack/webpack}	1086	4.85	974.10	-10.20%	`██▆▅▆▆▇▆▇▆▄▇▇▆▃▆▆▅▅▃`	19
_{wireapp/wire-desktop}	43	0.85	222.33	-5.57%	`█▇▇▇▇█▆▇▃▇▆▇▇▅▅▄▃▅▄▄`	19
_{wireapp/wire-webapp}	1227	7.79	666.20	-4.64%	`▇▄▇█▅▇█▇▅▆▆█▇▆▄▄▇▅▅▅`	19

Jason3S · 2024-10-16T07:25:34Z

@benmccann and @SuperchupuDev,

I'm going to have to roll this back. It seems that leading ! in globs causes the whole thing to fail.

I'll add some unit tests to catch this issue in the future.

Jason3S · 2024-10-16T07:26:43Z

@benmccann and @SuperchupuDev,

Thank you for your efforts!

SuperchupuDev · 2024-10-16T08:24:24Z

interesting, i do know that leading ! on absolute patterns can break, but just to make sure it's not something else, would you mind sending me a example of a breaking pattern as it gets passed to tinyglobby?

Jason3S · 2024-10-16T11:43:02Z

@SuperchupuDev,

The issues is with the ignore option. If it contains a glob starting with ! no results are returned.

benmccann · 2024-10-25T12:35:35Z

It looks like tinyglobby 0.2.10 was updated to match the behavior of fast-glob when a negated ignore pattern is provided

chore: replace fast-glob with tinyglobby

d4e8a8a

benmccann force-pushed the tinyglobby branch from a927e46 to d4e8a8a Compare August 26, 2024 15:54

Update glob.ts

5f0f824

ignore spelling Signed-off-by: Jason Dent <Jason3S@users.noreply.github.com>

Jason3S added a commit that referenced this pull request Aug 27, 2024

test: expand the snapshots

2adaf02

Expand the snapshots for a few integration test repos to show all issues. This will help to see why the results in #6167 are failing.

Jason3S mentioned this pull request Aug 27, 2024

test: expand the snapshots #6173

Merged

Jason3S added 3 commits August 27, 2024 07:45

Merge branch 'main' into tinyglobby

cf8e8c7

Merge branch 'main' into tinyglobby

fdd8600

Merge branch 'main' into tinyglobby

43095ea

benmccann marked this pull request as draft August 27, 2024 20:48

benmccann closed this Aug 27, 2024

benmccann mentioned this pull request Sep 29, 2024

Skip symlinks SuperchupuDev/tinyglobby#26

Closed

upgrade to latest tinyglobby

9946fcb

benmccann reopened this Sep 30, 2024

merge main

c041999

benmccann marked this pull request as ready for review September 30, 2024 17:45

restore symlink options

fdc2b5e

SuperchupuDev reviewed Sep 30, 2024

View reviewed changes

packages/cspell/src/app/util/glob.ts Show resolved Hide resolved

benmccann added 2 commits September 30, 2024 13:07

set expandDirectories: false

66798cd

bump

44bba54

Merge branch 'main' into tinyglobby

61b29fa

Merge branch 'main' into tinyglobby

2b0c3b7

Jason3S changed the title ~~chore: replace fast-glob with tinyglobby~~ feat: replace fast-glob with tinyglobby Oct 1, 2024

Jason3S merged commit 8f00d78 into streetsidesoftware:main Oct 1, 2024
88 checks passed

benmccann deleted the tinyglobby branch October 1, 2024 17:42

Jason3S added the feature label Oct 11, 2024

phansys mentioned this pull request Oct 16, 2024

[Bug]: BC break introduced in 8.15.0 #6373

Closed

1 task

Jason3S mentioned this pull request Oct 16, 2024

[Bug]: no files found for v8.15.0 #6353

Closed

1 task

benmccann mentioned this pull request Oct 16, 2024

Support for negated ignore patterns SuperchupuDev/tinyglobby#32

Open

benmccann mentioned this pull request Oct 26, 2024

chore: upgrade to tinyglobby 0.2.10 #6419

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: replace fast-glob with tinyglobby #6167

feat: replace fast-glob with tinyglobby #6167

benmccann commented Aug 26, 2024 •

edited

Loading

Jason3S commented Aug 27, 2024

Jason3S commented Aug 27, 2024

Jason3S commented Aug 27, 2024

benmccann commented Aug 27, 2024

Jason3S commented Aug 28, 2024

SuperchupuDev commented Aug 28, 2024

SuperchupuDev commented Sep 30, 2024

benmccann commented Sep 30, 2024

ghiscoding commented Oct 1, 2024

SuperchupuDev commented Oct 1, 2024

Jason3S commented Oct 1, 2024

github-actions bot commented Oct 1, 2024

Jason3S commented Oct 16, 2024

Jason3S commented Oct 16, 2024

SuperchupuDev commented Oct 16, 2024

Jason3S commented Oct 16, 2024

benmccann commented Oct 25, 2024

feat: replace fast-glob with tinyglobby #6167

feat: replace fast-glob with tinyglobby #6167

Conversation

benmccann commented Aug 26, 2024 • edited Loading

Jason3S commented Aug 27, 2024

Jason3S commented Aug 27, 2024

Jason3S commented Aug 27, 2024

benmccann commented Aug 27, 2024

Jason3S commented Aug 28, 2024

SuperchupuDev commented Aug 28, 2024

SuperchupuDev commented Sep 30, 2024

benmccann commented Sep 30, 2024

ghiscoding commented Oct 1, 2024

SuperchupuDev commented Oct 1, 2024

Jason3S commented Oct 1, 2024

github-actions bot commented Oct 1, 2024

Performance Report

Daily Performance

Time to Process Files

Files per Second over Time

Data Throughput

Jason3S commented Oct 16, 2024

Jason3S commented Oct 16, 2024

SuperchupuDev commented Oct 16, 2024

Jason3S commented Oct 16, 2024

benmccann commented Oct 25, 2024

benmccann commented Aug 26, 2024 •

edited

Loading