Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: no files found for v8.15.0 #6353

Closed
1 task done
calvinballing opened this issue Oct 11, 2024 · 11 comments · Fixed by #6388
Closed
1 task done

[Bug]: no files found for v8.15.0 #6353

calvinballing opened this issue Oct 11, 2024 · 11 comments · Fixed by #6388

Comments

@calvinballing
Copy link

calvinballing commented Oct 11, 2024

Kind of Issue

Runtime - command-line tools, Change in behavior / Regression

Tool or Library

cspell

Version

8.15.0

Supporting Library

Not sure / None

OS

Windows

OS Version

Windows 10 Enterprise

Description

v8.14.4 works fine, but updating to v8.15.0 no files are found when running from the command line

“CSpell: Files checked: 0, Issues found: 0 in 0 files.”

Steps to Reproduce

Command line “npx cspell “**” ”

Expected Behavior

Find files

Additional Information

No response

cspell.json

No response

cspell.config.yaml

No response

Example Repository

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Jason3S
Copy link
Collaborator

Jason3S commented Oct 11, 2024

@calvinballing,

Thank you. I'll check it out.

@Jason3S
Copy link
Collaborator

Jason3S commented Oct 11, 2024

@calvinballing,

image

Can you include the contents of your config? The glob lib was changed, so it might be related. Or a combination when it comes to Windows and globs.

  • The ignorePaths are the most important.
  • Do you use symbolic links?

@Jason3S
Copy link
Collaborator

Jason3S commented Oct 12, 2024

I found a Windows machine and tried it:

image

So, I'm thinking it is related to the ignorePaths setting. I would like to find out which one is breaking.

@amotarao
Copy link

amotarao commented Oct 15, 2024

@Jason3S

The same issue occurs on both macOS and Ubuntu (GitHub Actions).
When I run cspell within packages/foobar, it reports 0 files.
The following entries are included in the ignorePaths configuration:

    "packages/foobar/src/module/*",
    "!packages/foobar/src/module/**/index.ts",

It works when I comment out !packages/foobar/src/module/**/index.ts, so it seems that the syntax for the negation pattern may need to be adjusted.

@Jason3S
Copy link
Collaborator

Jason3S commented Oct 16, 2024

This was caused by #6167
Looking for a fix.

@Jason3S Jason3S changed the title [Bug]: no files found in Windows in v8.15.0 [Bug]: no files found for v8.15.0 Oct 16, 2024
@SuperchupuDev
Copy link

if you can provide a minimal repro using just tinyglobby i can try to fix it upstream

@Jason3S
Copy link
Collaborator

Jason3S commented Oct 17, 2024

SuperchupuDev/tinyglobby#63

@SuperchupuDev
Copy link

SuperchupuDev commented Oct 17, 2024

should be fixed upstream now, and if everything goes well will be included in the next tinyglobby version. you can test the fix by using the following preview build in this project's package.json:

  "tinyglobby": "https://pkg.pr.new/tinyglobby@b43ffdf",

@Jason3S
Copy link
Collaborator

Jason3S commented Oct 18, 2024

@SuperchupuDev,

Thank you! It seems to work.

@SuperchupuDev
Copy link

FYI the upstream fix has just been released in tinyglobby 0.2.10

@Jason3S
Copy link
Collaborator

Jason3S commented Oct 30, 2024

@SuperchupuDev,

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants