Set max connections for plan cmd (#93)

stripe · Jan 25, 2024 · 75764a0 · 75764a0
1 parent 266b6bd
commit 75764a0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/cmd/pg-schema-diff/plan_cmd.go b/cmd/pg-schema-diff/plan_cmd.go
@@ -242,6 +242,8 @@ func generatePlan(ctx context.Context, logger log.Logger, connConfig *pgx.ConnCo
 	}
 	defer connPool.Close()
 
+	connPool.SetMaxOpenConns(5)
+
 	plan, err := diff.GeneratePlan(ctx, connPool, tempDbFactory, ddl,
 		diff.WithDataPackNewTables(),
 	)

diff --git a/pkg/diff/plan_generator.go b/pkg/diff/plan_generator.go
@@ -62,7 +62,7 @@ func WithLogger(logger log.Logger) PlanOpt {
 //
 // Parameters:
 // queryable: 	The target database to generate the diff for. It is recommended to pass in *sql.DB of the db you
-// wish to migrate.
+// wish to migrate. If using a connection pool, it is RECOMMENDED to set a maximum number of connections.
 // tempDbFactory:  	used to create a temporary database instance to extract the schema from the new DDL and validate the
 // migration plan. It is recommended to use tempdb.NewOnInstanceFactory, or you can provide your own.
 // newDDL:  		DDL encoding the new schema