-
Notifications
You must be signed in to change notification settings - Fork 976
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
## Summary Previous PR: #4150 Makes EmbeddedPaymentElement view a view that contains embedded view so we can swap to the updated embedded view with an animation. Makes EmbeddedPaymentElement restore previous customer in **_payment method list selection_ (1)** on `update`, call `didUpdateHeight` and `didUpdatePaymentOption` if necessary. Still to come: - Restore previous customer input in ***form (2)*** + E2E tests (e.g. load PI -> fill out card form -> update to SI -> expect form to be preserved but w/o checkbox) - Make confirm handle in-flight and failed update calls. - (Bonus) Cancel network calls etc. from previous update to reduce battery/network usage. Can apply this to FC.update as well. ## Motivation https://jira.corp.stripe.com/browse/MOBILESDK-2583 ## Testing See test ## Changelog Not user facing
- Loading branch information
1 parent
2de3f87
commit 6d884c3
Showing
8 changed files
with
228 additions
and
120 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.