-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedded update pt 3 #4168
Merged
Merged
Embedded update pt 3 #4168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 Snapshot TestNo snapshots generated
🛸 Powered by Emerge Tools |
yuki-stripe
force-pushed
the
yuki/update-pt-3
branch
from
October 21, 2024 17:17
20f6d97
to
a7c325f
Compare
🚨 New dead code detected in this PR: EmbeddedPaymentMethodsView.swift:9 warning: Imported module 'StripeCore' is unused Please remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
yuki-stripe
force-pushed
the
yuki/update-pt-3
branch
from
October 22, 2024 00:08
c015f5d
to
81dbf98
Compare
porter-stripe
approved these changes
Oct 22, 2024
yuki-stripe
added a commit
that referenced
this pull request
Oct 23, 2024
Previous PR: #4168 Still to come: - Restore previous customer input in form (2) + E2E tests (e.g. load PI -> fill out card form -> update to SI -> expect form to be preserved but w/o checkbox) - (Bonus) Cancel network calls etc. from previous update to reduce battery/network usage. Can apply this to FC.update as well. ## Motivation https://jira.corp.stripe.com/browse/MOBILESDK-2583 ## Testing See unit tests ## Changelog Not user facing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previous PR: #4150
Makes EmbeddedPaymentElement view a view that contains embedded view so we can swap to the updated embedded view with an animation.
Makes EmbeddedPaymentElement restore previous customer in payment method list selection (1) on
update
, calldidUpdateHeight
anddidUpdatePaymentOption
if necessary.Still to come:
Motivation
https://jira.corp.stripe.com/browse/MOBILESDK-2583
Testing
See test
Changelog
Not user facing