Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded update pt 3 #4168

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Embedded update pt 3 #4168

merged 5 commits into from
Oct 22, 2024

Conversation

yuki-stripe
Copy link
Collaborator

Summary

Previous PR: #4150
Makes EmbeddedPaymentElement view a view that contains embedded view so we can swap to the updated embedded view with an animation.

Makes EmbeddedPaymentElement restore previous customer in payment method list selection (1) on update, call didUpdateHeight and didUpdatePaymentOption if necessary.

Still to come:

  • Restore previous customer input in form (2) + E2E tests (e.g. load PI -> fill out card form -> update to SI -> expect form to be preserved but w/o checkbox)
  • Make confirm handle in-flight and failed update calls.
  • (Bonus) Cancel network calls etc. from previous update to reduce battery/network usage. Can apply this to FC.update as well.

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-2583

Testing

See test

Changelog

Not user facing

Copy link

emerge-tools bot commented Oct 21, 2024

📸 Snapshot Test

No snapshots generated

Name Version Added Removed Modified Unchanged Errored Approval
StripePaymentSheetSize
com.stripe.StripePaymentSheetSize
1.0 (1) 0 0 0 0 0 N/A
StripePaymentsUISize
com.stripe.StripePaymentsUISize
1.0 (1) 0 0 0 0 0 N/A
StripePaymentsSize
com.stripe.StripePaymentsSize
1.0 (1) 0 0 0 0 0 N/A
StripeApplePaySize
com.stripe.StripeApplePaySize
1.0 (1) 0 0 0 0 0 N/A
StripeFinancialConnectionsSize
com.stripe.StripeFinancialConnectionsSize
1.0 (1) 0 0 0 0 0 N/A
StripeSize
com.stripe.StripeSize
1.0 (1) 0 0 0 0 0 N/A

🛸 Powered by Emerge Tools

Copy link

github-actions bot commented Oct 21, 2024

🚨 New dead code detected in this PR:

EmbeddedPaymentMethodsView.swift:9 warning: Imported module 'StripeCore' is unused

Please remove the dead code before merging.

If this is intentional, you can bypass this check by adding the label skip dead code check to this PR.

ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with master.

@yuki-stripe yuki-stripe merged commit 6d884c3 into master Oct 22, 2024
6 checks passed
@yuki-stripe yuki-stripe deleted the yuki/update-pt-3 branch October 22, 2024 15:59
yuki-stripe added a commit that referenced this pull request Oct 23, 2024
Previous PR: #4168

Still to come:

- Restore previous customer input in form (2) + E2E tests (e.g. load PI
-> fill out card form -> update to SI -> expect form to be preserved but
w/o checkbox)
- (Bonus) Cancel network calls etc. from previous update to reduce
battery/network usage. Can apply this to FC.update as well.

## Motivation
https://jira.corp.stripe.com/browse/MOBILESDK-2583

## Testing
See unit tests

## Changelog
Not user facing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants