Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status bar customisation for STPThreeDSCustomizationSettings #1253

Closed
tombates-pdr opened this issue Jul 26, 2019 · 6 comments
Closed

Status bar customisation for STPThreeDSCustomizationSettings #1253

tombates-pdr opened this issue Jul 26, 2019 · 6 comments
Assignees
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally

Comments

@tombates-pdr
Copy link

Summary

It would be mega if we could pass in a UIStatusBarStyle to the STPThreeDSCustomizationSettings. Currently, I think it just uses the default

Installation method

Cocoapods

SDK version

16.0.1

@mshafrir-stripe mshafrir-stripe added the triaged Issue has been reviewed by Stripe and is being tracked internally label Jul 26, 2019
@yuki-stripe
Copy link
Collaborator

Agreed, thanks for the feedback @DrTomBates. We're tracking this internally.

@yuki-stripe
Copy link
Collaborator

@DrTomBates This will be in the next release!

@tombates-pdr
Copy link
Author

@yuki-stripe Just having a look at implementing this. It looks like I can set the status bar color only on STDSUICustomization I need this to be exposed through STPThreeDSUICustomization unless I am missing something?

@yuki-stripe
Copy link
Collaborator

@DrTomBates Ah you're totally right, thanks. Fixing here: #1296

@yuki-stripe
Copy link
Collaborator

@DrTomBates FYI:

I've removed preferredStatusBarStyle since it doesn't actually do anything in our case (because our UIViewControllers are in a UINavigationController). Instead, set the barStyle to .black to set the statusBarStyle to .lightContent. You can still control the color of the navigation bar via the barTintColor and translucent properties. Confusing, but this is how it works on iOS!

Check out the summary here #1308

@tombates-pdr
Copy link
Author

Thanks for the heads up @yuki-stripe
It is indeed strange to have to set the navigation bar to black to then change it to blue, I had thought that you would have subclassed UINavigationController and returned the preferedStatusBarStyle from that.
This solution works just as well though, by the looks of it and you don't need to subclass.
Every day is a school day.

Simulator Screen Shot - iPhone Xs - 2019-08-22 at 15 00 59

wooj-stripe pushed a commit that referenced this issue Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally
Projects
None yet
Development

No branches or pull requests

3 participants