Remove preferredStatusBarStyle from STPThreeDSUICustomization #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidme-stripe
approved these changes
Aug 21, 2019
This was referenced Aug 21, 2019
yuki-stripe
added a commit
that referenced
this pull request
Aug 23, 2019
* Remove preferredStatusBarStyle from STPThreeDSUICustomization * Fix test (cherry picked from commit 92b0fd4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It turns out this property doesn't work as expected. When a
UIViewControlleris in aUINavigationController(always for our 3DS2 SDK), theUINavigationController.barStyledecides what color the status bar is.Since it therefore does nothing, I've removed it and documented how to use
barStyleto control the color instead.[0] https://forums.developer.apple.com/thread/30435
Motivation
#1301
Testing
Tested dark mode configuration in Standard Integration example app, works as expected. Not committing it b/c we are implementing a better version soon here #1307