STPPaymentCardTextField shouldn't attempt to becomeFirstResponder while being dismissed #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en being dismissed
csabol-stripe
approved these changes
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #1009 STPPaymentCardTextField started calling
[self.numberField becomeFirstResponder]when being presented in certain situations, but we don't want that behavior if the card field is in the process of being dismissed.Motivation
Without this fix, the keyboard quickly appears and disappears when the another field is dismissed while the card number is invalid, which is visually distracting and sends spurious
keyboardWillShownotifications. This was filed as #1388.Testing
Tested in the UI Examples project on my iPhone running iOS 13.