Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Swift Package Manager #1644

Merged
merged 3 commits into from
Sep 12, 2020
Merged

Conversation

davidme-stripe
Copy link
Contributor

@davidme-stripe davidme-stripe commented Sep 11, 2020

Summary

  • Add support for Swift Package Manager
  • Move files around to fit SPM's preferred structure, including moving images to Asset Catalogs
  • Add support for finding the Stripe bundle resources from an SPM bundle (This change snuck into Remove iOS 10 support, update Stripe3DS2 #1643 instead)
  • Add a Swift Package Manager install test
  • Disable NSAsserts in the release version of Stripe.framework for consistency with Cocoapods and SPM (and a small binary size win)
  • Remove deprecated StripeiOS-static scheme
  • Update README

Testing

Tested in CI, and with test projects on SPM and Cocoapods.

Base automatically changed from davidme/drop-ios-10-open-ssl to master September 11, 2020 23:51
@@ -6,5 +6,3 @@
//

#include "StripeiOS-Shared.xcconfig"

ENABLE_NS_ASSERTIONS = YES
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants