Make embedded confirm handle in-flight and failed update calls. #4174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooj-stripe
reviewed
Oct 22, 2024
Comment on lines
172
to
173
| case .succeeded: | ||
| break |
There was a problem hiding this comment.
if the update succeeds, should we attempt to confirm at this point?
There was a problem hiding this comment.
Yep, that's what happens in this code (except we haven't written the code to confirm yet). I'll move the comment in line 185 to make that more obvious.
wooj-stripe
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: #4168
Still to come:
Motivation
https://jira.corp.stripe.com/browse/MOBILESDK-2583
Testing
See unit tests
Changelog
Not user facing