Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genesis Sample 3.0.0 release #268

Merged
merged 47 commits into from
Jun 19, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
2e9099e
Prevent form creation attempts if WPForms Lite version is < 1.5.2
nickcernis May 1, 2019
972580c
Switch to sticky positioning
dreamwhisper May 3, 2019
a102bf1
Remove margin script
dreamwhisper May 3, 2019
299214e
Autoprefix sticky positioning
dreamwhisper May 3, 2019
66c03e6
Update CSS for WordPress 5.2 column fixes
dreamwhisper May 8, 2019
0fb48ee
Remove 404 page support from accessibility config
nickcernis May 20, 2019
8bba7d2
Replace responsive menu scripts with genesis_register_responsive_menu…
nickcernis May 6, 2019
d16bbaf
Extract responsive menu config
nickcernis May 9, 2019
b939531
Conditionally load AMP CSS fixes if AMP is active
nickcernis May 9, 2019
05ad8b8
Remove unneeded prefixes
nickcernis May 9, 2019
1fae08e
CSS standards
nickcernis May 9, 2019
de7ae3b
Fix submenu hover on AMP version
nickcernis May 13, 2019
3777f22
Remove responsive menus script
nickcernis May 15, 2019
8584131
Use child theme handle constant in place of hard-coded theme handle
nickcernis May 15, 2019
8898be1
Add AMP CSS to lint:css script
nickcernis May 15, 2019
6041d2f
Lint AMP CSS
nickcernis May 15, 2019
efc13d1
Update package versions
nickcernis May 28, 2019
6e6cfba
Bump version to 3.0.0-beta
nickcernis May 28, 2019
ff39392
Remove viewport theme support
dreamwhisper Jun 3, 2019
e0c06f1
Combine default color helper functions and add color palette config
seothemes Jun 3, 2019
aa982d0
Remove all constants and replace with new helpers
seothemes Jun 2, 2019
e87c061
Replace strings where possible
seothemes Jun 2, 2019
d67cf49
Remove settings metabox edits
dreamwhisper Jun 5, 2019
2656083
Merge pull request #259 from studiopress/remove/settings-metabox-removal
nickcernis Jun 5, 2019
bdf9638
Use fonts url from config and add font-display arg. Closes #249
seothemes Jun 5, 2019
00f63c0
Remove Genesis-specific theme settings files
nickcernis Jun 11, 2019
02b3630
Merge pull request #262 from studiopress/remove/child-theme-settings-…
dreamwhisper Jun 11, 2019
3e45200
Refactor config files
nickcernis Jun 13, 2019
50c81b5
Remove `genesis_sample_get_default_color` helper function
nickcernis Jun 13, 2019
6b99e3c
Remove other genesis_sample_get_default_color calls
nickcernis Jun 13, 2019
a11c2f2
Split default colors into separate array
nickcernis Jun 13, 2019
ac05df9
Delete Genesis nav right extra filter removal
nickcernis Jun 13, 2019
c72be20
Declare accent color at the top for consistency
nickcernis Jun 14, 2019
7e455ea
Drop 'default' prefix from appearance keys where not needed
nickcernis Jun 14, 2019
9fc631d
Add `composer phpcbf` command and document
nickcernis Jun 14, 2019
48b6135
Merge pull request #265 from studiopress/fix/nav-extras
dreamwhisper Jun 14, 2019
10f1c9d
Merge pull request #266 from studiopress/add/phpcbf
dreamwhisper Jun 14, 2019
3be4241
Fix priority of after_setup_theme action
nickcernis Jun 14, 2019
c9b4c44
Merge pull request #264 from studiopress/refactor/config
dreamwhisper Jun 14, 2019
15727f2
Bump version to 3.0.0
nickcernis Jun 17, 2019
0c329de
Update language file
nickcernis Jun 17, 2019
863de8c
Add changelog for 3.0.0
nickcernis Jun 17, 2019
d3824f4
Mention makepot command in GitHub issue release template
nickcernis Jun 17, 2019
1b4e6c4
Add link to 2.8.0/3.0.0 diff
nickcernis Jun 17, 2019
e28ccf2
Fix diff links
nickcernis Jun 17, 2019
5ee06b0
Correct 3.0.0 release date
nickcernis Jun 17, 2019
12e8e0f
Merge pull request #267 from studiopress/release/3.0.0
dreamwhisper Jun 17, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
node_modules
vendor
*.min.js
js/responsive-menus.js
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/release.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ assignees: ''
**Update version**
- [ ] style.css
- [ ] package.json
- [ ] .pot file (regenerate)
- [ ] .pot file (`npm install` then `npm run makepot`)
- [ ] Changelog (include changes)

**Check standards**
Expand Down
41 changes: 34 additions & 7 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,28 @@
# Genesis Sample Theme Changelog

## [3.0.0] - 2019-06-19
Requires Genesis 3.0.0+.

### Added
* AMP support. (Optional, off by default, requires Genesis 3.0.0 and the [AMP plugin](https://wordpress.org/plugins/amp/).)
* New `composer run phpcbf` command to fix simple PHP linting violations. ([GitHub version](https://github.com/studiopress/genesis-sample/) only.)

### Changed
* Use `position: sticky` for the header and remove JavaScript that adjusted header height and content position. This prevents content reflow after page load.
* Reorganized config folder for easier reading and maintenance.
* Use new `genesis_get_theme_handle()` and `genesis_get_theme_version()` functions from Genesis 3.0.0 in place of declaring `CHILD_THEME_HANDLE` and `CHILD_THEME_VERSION` constants.
* Update developer dependencies.

### Fixed
* Improved block column CSS for WordPress 5.2+.

### Removed
* Responsive menu scripts have been replaced with `genesis_register_responsive_menus()`, which loads required JavaScript from Genesis 3.0.0.
* `genesis-responsive-viewport` theme support declaration. This is now added by default in Genesis 3.0.0.
* Deleted Genesis nav extras filter and metabox removal. These are no longer present in Genesis 3.0.0.
* `child-theme-settings-genesis.php` file and filter. Genesis 3.0.0 no longer includes a settings admin page or `genesis_theme_settings_defaults` filter.
* `404-page` accessibility support, as this no longer has an effect.

## [2.10.0] - 2019-05-01
Requires Genesis 2.10.0+.

Expand Down Expand Up @@ -116,10 +139,14 @@ Requires Genesis 2.8.0+.
* Set localization.
* Update XML file.

[2.8.0]: https://github.com/copyblogger/genesis-sample/compare/2.7.1...2.8.0
[2.7.1]: https://github.com/copyblogger/genesis-sample/compare/2.7.0...2.7.1
[2.7.0]: https://github.com/copyblogger/genesis-sample/compare/2.6.0...2.7.0
[2.6.0]: https://github.com/copyblogger/genesis-sample/compare/2.3.0...2.6.0
[2.3.0]: https://github.com/copyblogger/genesis-sample/compare/2.2.4...2.3.0
[2.2.4]: https://github.com/copyblogger/genesis-sample/compare/2.2.3...2.2.4
[2.2.3]: https://github.com/copyblogger/genesis-sample/compare/014deb3689323b7bbd4ddbfff4f5f9279a38f741...2.2.3
[3.0.0]: https://github.com/studiopress/genesis-sample/compare/2.10.0...3.0.0
[2.10.0]: https://github.com/studiopress/genesis-sample/compare/2.9.1...2.10.0
[2.9.1]: https://github.com/studiopress/genesis-sample/compare/2.9.0...2.9.1
[2.9.0]: https://github.com/studiopress/genesis-sample/compare/2.8.0...2.9.0
[2.8.0]: https://github.com/studiopress/genesis-sample/compare/2.7.1...2.8.0
[2.7.1]: https://github.com/studiopress/genesis-sample/compare/2.7.0...2.7.1
[2.7.0]: https://github.com/studiopress/genesis-sample/compare/2.6.0...2.7.0
[2.6.0]: https://github.com/studiopress/genesis-sample/compare/2.3.0...2.6.0
[2.3.0]: https://github.com/studiopress/genesis-sample/compare/2.2.4...2.3.0
[2.2.4]: https://github.com/studiopress/genesis-sample/compare/2.2.3...2.2.4
[2.2.3]: https://github.com/studiopress/genesis-sample/compare/014deb3689323b7bbd4ddbfff4f5f9279a38f741...2.2.3
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ The version of [Genesis Sample on GitHub](https://github.com/studiopress/genesis

You'll see output highlighting issues with PHP files that do not conform to Genesis Sample coding standards.

Run `composer phpcbf` if you see “phpcbf can fix the x marked sniff violations automatically” in the output of `composer phpcs`.

### npm scripts

Scripts are also provided to help with CSS linting, CSS autoprefixing, and creation of pot language files. To use them:
Expand Down
3 changes: 2 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@
},
"scripts": {
"install-codestandards": "Dealerdirect\\Composer\\Plugin\\Installers\\PHPCodeSniffer\\Plugin::run",
"phpcs": "phpcs"
"phpcs": "phpcs",
"phpcbf": "phpcbf"
},
"support": {
"issues": "https://github.com/studiopress/genesis-sample/issues",
Expand Down
39 changes: 27 additions & 12 deletions config/block-editor-settings.php → config/appearance.php
Original file line number Diff line number Diff line change
@@ -1,37 +1,52 @@
<?php
/**
* Block Editor settings specific to Genesis Sample.
* Genesis Sample appearance settings.
*
* @package Genesis Sample
* @author StudioPress
* @license GPL-2.0-or-later
* @link https://www.studiopress.com/
*/

$genesis_sample_link_color = get_theme_mod( 'genesis_sample_link_color', genesis_sample_customizer_get_default_link_color() );
$genesis_sample_default_colors = array(
'link' => '#0073e5',
'accent' => '#0073e5',
);

$genesis_sample_link_color = get_theme_mod(
'genesis_sample_link_color',
$genesis_sample_default_colors['link']
);

$genesis_sample_accent_color = get_theme_mod(
'genesis_sample_accent_color',
$genesis_sample_default_colors['accent']
);

$genesis_sample_link_color_contrast = genesis_sample_color_contrast( $genesis_sample_link_color );
$genesis_sample_link_color_brightness = genesis_sample_color_brightness( $genesis_sample_link_color, 35 );

return array(
'admin-fonts-url' => 'https://fonts.googleapis.com/css?family=Source+Sans+Pro:400,400i,600,700',
'content-width' => 1062,
'default-button-bg' => $genesis_sample_link_color,
'default-button-color' => $genesis_sample_link_color_contrast,
'default-button-outline-hover' => $genesis_sample_link_color_brightness,
'default-link-color' => $genesis_sample_link_color,
'editor-color-palette' => array(
'fonts-url' => 'https://fonts.googleapis.com/css?family=Source+Sans+Pro:400,400i,600,700&display=swap',
'content-width' => 1062,
'button-bg' => $genesis_sample_link_color,
'button-color' => $genesis_sample_link_color_contrast,
'button-outline-hover' => $genesis_sample_link_color_brightness,
'link-color' => $genesis_sample_link_color,
'default-colors' => $genesis_sample_default_colors,
'editor-color-palette' => array(
array(
'name' => __( 'Custom color', 'genesis-sample' ), // Called “Link Color” in the Customizer options. Renamed because “Link Color” implies it can only be used for links.
'slug' => 'theme-primary',
'color' => get_theme_mod( 'genesis_sample_link_color', genesis_sample_customizer_get_default_link_color() ),
'color' => $genesis_sample_link_color,
),
array(
'name' => __( 'Accent color', 'genesis-sample' ),
'slug' => 'theme-secondary',
'color' => get_theme_mod( 'genesis_sample_accent_color', genesis_sample_customizer_get_default_accent_color() ),
'color' => $genesis_sample_accent_color,
),
),
'editor-font-sizes' => array(
'editor-font-sizes' => array(
array(
'name' => __( 'Small', 'genesis-sample' ),
'size' => 12,
Expand Down
32 changes: 0 additions & 32 deletions config/child-theme-settings-genesis.php

This file was deleted.

19 changes: 18 additions & 1 deletion config/child-theme-settings.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,23 @@
*/

return array(
GENESIS_SETTINGS_FIELD => genesis_get_config( 'child-theme-settings-genesis' ),
GENESIS_SETTINGS_FIELD => array(
'blog_cat_num' => 6,
'breadcrumb_home' => 0,
'breadcrumb_front_page' => 0,
'breadcrumb_posts_page' => 0,
'breadcrumb_single' => 0,
'breadcrumb_page' => 0,
'breadcrumb_archive' => 0,
'breadcrumb_404' => 0,
'breadcrumb_attachment' => 0,
'content_archive' => 'full',
'content_archive_limit' => 0,
'content_archive_thumbnail' => 0,
'image_size' => '',
'image_alignment' => 'alignleft',
'posts_nav' => 'numeric',
'site_layout' => 'content-sidebar',
),
'posts_per_page' => 6,
);
19 changes: 0 additions & 19 deletions config/custom-logo.php

This file was deleted.

20 changes: 0 additions & 20 deletions config/html5.php

This file was deleted.

17 changes: 0 additions & 17 deletions config/menus.php

This file was deleted.

15 changes: 9 additions & 6 deletions config/accessibility.php → config/responsive-menus.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,15 @@
*/

/**
* Genesis Accessibility features to support.
* Genesis responsive menus settings. (Requires Genesis 3.0+.)
*/
return array(
'404-page',
'drop-down-menu',
'headings',
'search-form',
'skip-links',
'script' => array(
'menuClasses' => array(
'others' => array( '.nav-primary' ),
),
),
'extras' => array(
'media_query_width' => '960px',
),
);
39 changes: 39 additions & 0 deletions config/theme-supports.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<?php
/**
* Genesis Sample child theme.
*
* Theme supports.
*
* @package Genesis Sample
* @author StudioPress
* @license GPL-2.0-or-later
* @link https://my.studiopress.com/themes/genesis-sample/
*/

return array(
'custom-logo' => array(
'height' => 120,
'width' => 700,
'flex-height' => true,
'flex-width' => true,
),
'html5' => array(
'caption',
'comment-form',
'comment-list',
'gallery',
'search-form',
),
'genesis-accessibility' => array(
'drop-down-menu',
'headings',
'search-form',
'skip-links',
),
'genesis-after-entry-widget-area' => '',
'genesis-footer-widgets' => 3,
'genesis-menus' => array(
'primary' => __( 'Header Menu', 'genesis-sample' ),
'secondary' => __( 'Footer Menu', 'genesis-sample' ),
),
);
Loading