Genesis Sample 3.0.0 release #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating a working form via the WPForms API requires 1.5.2 or higher. If the site already has WPForms Lite installed but it's an older version, form creation will fail, breaking the onboarding process.
This is no longer used in Genesis, so has no effect.
Loads these files from the Genesis AMP plugin (relocated to the theme): - theme-fixer/genesis-amp-animated.css - theme-fixer/themes/genesis-sample/stylesheet.css (omits .woocommerce) This allows the menu to function on AMP and regular versions when used with this version of the Genesis AMP plugin that omits all 'theme fixer' functionality: https://github.com/nickcernis/genesis-amp/tree/suppress-theme-fixer Still need to: - Discuss if genesis-amp-animated.css belongs in Genesis or the theme. - Look into not loading a separate stylesheet conditionally for AMP. It would be easier to maintain if the AMP menu CSS was part of the theme's main style.css.
These are not needed for modern AMP-ready browsers.
Ensures submenus appear on hover instead of only on focus. Props @dreamwhisper.
This will be served from Genesis itself from Genesis 3.0.0+ and enqueued automatically when using the `genesis_register_responsive_menus` function.
Support for the viewport meta tag is added by default in Genesis 3.0
Since 3.0 removes settings pages and Sample 3.0 requires Genesis 3.0, remove the edits we had in place to remove specific metaboxes.
Remove settings metabox edits
Genesis 3.0+ does not have a theme settings admin page or `genesis_theme_settings_defaults` filter, so I've removed that filter from theme-defaults.php. As the Genesis settings are then no longer needed in two places, I moved settings from `child-theme-settings-genesis.php` to the main `child-theme-settings.php` file.
…reset Remove Genesis-specific theme settings files
Fixes #260.
We can retrieve the default color from the appearance config instead. We don't have getter functions to retrieve other preferences, so it seems unnecessary to have one for the colors alone.
This allows them to be referenced inside the returned array, preventing a PHP warning.
These are no longer applied in Genesis 3.0.
Delete Genesis nav right extra filter removal
Add `composer phpcbf` command and document
This ensures widget areas get added.
Refactor config files
Genesis Sample 3.0.0
dreamwhisper
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.0.0 scheduled for 2019-06-19
Requires Genesis 3.0.0+.
Added
composer run phpcbfcommand to fix simple PHP linting violations. (GitHub version only.)Changed
position: stickyfor the header and remove JavaScript that adjusted header height and content position. This prevents content reflow after page load.genesis_get_theme_handle()andgenesis_get_theme_version()functions from Genesis 3.0.0 in place of declaringCHILD_THEME_HANDLEandCHILD_THEME_VERSIONconstants.Fixed
Removed
genesis_register_responsive_menus(), which loads required JavaScript from Genesis 3.0.0.genesis-responsive-viewporttheme support declaration. This is now added by default in Genesis 3.0.0.child-theme-settings-genesis.phpfile and filter. Genesis 3.0.0 no longer includes a settings admin page orgenesis_theme_settings_defaultsfilter.404-pageaccessibility support, as this no longer has an effect.