Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to substrait v0.57.0 #300

Merged
merged 4 commits into from
Oct 4, 2024
Merged

chore: update to substrait v0.57.0 #300

merged 4 commits into from
Oct 4, 2024

Conversation

kadinrabo
Copy link
Contributor

  1. Upgrade submodule to 0.57
  2. Update conversion visitors to handle new set op types (708) SET_OP_MINUS_PRIMARY_ALL & SET_OP_INTERSECTION_MULTISET_ALL
  3. Does not address the new grouping behavior in AggregateRel #299

chore(release): 0.57.0
ci: bump semantic-release to 24.1.2 (#718)
chore(deps): Bump bufbuild/buf-setup-action from 1.42.0 to 1.43.0 (#717)
feat: make substrait repo a go module (#712)
feat: clarify behaviour of SetRel operations (#708)
feat: change grouping expressions in AggregateRel to references (#706)
chore(deps): Bump bufbuild/buf-setup-action from 1.41.0 to 1.42.0 (#709)

@vbarua vbarua self-requested a review October 2, 2024 23:01
vbarua
vbarua requested changes Oct 3, 2024
View reviewed changes
Copy link
Member

@vbarua vbarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just have 2 minor changes I would like to see, but other than that this looks good to merge.

isthmus/src/main/java/io/substrait/isthmus/SubstraitRelNodeConverter.java Show resolved Hide resolved
isthmus/src/test/java/io/substrait/isthmus/utils/SetUtils.java Show resolved Hide resolved
@kadinrabo kadinrabo requested a review from vbarua October 4, 2024 13:29
@vbarua vbarua mentioned this pull request Oct 4, 2024
Open
@vbarua vbarua force-pushed the kadin.rabo/update-substrait-0.57.0 branch from f4723f7 to 413fede Compare October 4, 2024 15:36
vbarua
vbarua approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@vbarua vbarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@vbarua vbarua merged commit eb484a3 into substrait-io:main Oct 4, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbarua vbarua vbarua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kadinrabo @vbarua