Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: num limbs #377

Closed
wants to merge 5 commits into from
Closed

Conversation

brozorec
Copy link
Contributor

There are already another two draft PRs tackling the exact same problem #365 and #367

Here, I propose a slightly different approach that has the following benefits:

  1. Less refactoring of the existing code: NUM_LIMBS is also passed as a generic but with a default value.
  2. No need to pass another generic when initializing Limbs: NUM_WITNESS_LIMBS is removed; this value is a function of NUM_LIMBS, so it can be computed. Added a new derive macro FieldsCols that computes this value and constructs FieldDenCols, FieldOpCols and FieldInnerProductCols structs.

With this PR, I'd just like to propose a rough outline of what can be done and see if this approach passes the team's temp check. Ready to collaborate with @0xkanekiken and eventually merge our works.

@puma314
Copy link
Contributor

puma314 commented Mar 22, 2024

Closing in favor of this approach: #417

@puma314 puma314 closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants