Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are already another two draft PRs tackling the exact same problem #365 and #367
Here, I propose a slightly different approach that has the following benefits:
NUM_LIMBS
is also passed as a generic but with a default value.Limbs
:NUM_WITNESS_LIMBS
is removed; this value is a function ofNUM_LIMBS,
so it can be computed. Added a new derive macroFieldsCols
that computes this value and constructsFieldDenCols
,FieldOpCols
andFieldInnerProductCols
structs.With this PR, I'd just like to propose a rough outline of what can be done and see if this approach passes the team's temp check. Ready to collaborate with @0xkanekiken and eventually merge our works.