refactor: generic size limbs for curve precompiles #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diff curves Signed-off-by: 0xkanekiken <100861945+0xKanekiKen@users.noreply.github.com>
Signed-off-by: 0xkanekiken <100861945+0xKanekiKen@users.noreply.github.com>
Signed-off-by: 0xkanekiken <100861945+0xKanekiKen@users.noreply.github.com>
puma314
reviewed
Mar 22, 2024
This was referenced Mar 22, 2024
Closed
puma314
reviewed
Mar 22, 2024
core/src/operations/field/params.rs
Outdated
| } | ||
|
|
||
| /// Implement NumWords for NumLimbs where # Limbs is divisible by 4. | ||
| impl<N: NumLimbs> NumWords for N |
There was a problem hiding this comment.
if you could leave a comment explaining wtf is going on here, that would be great :)
| @@ -53,14 +52,14 @@ pub struct EdAddAssignCols<T> { | |||
| pub q_ptr: T, | |||
| pub p_access: [MemoryWriteCols<T>; 16], | |||
There was a problem hiding this comment.
nit: shouldn't these be Ed25519BaseField::... for consistency?
|
|
||
| let p_x = limbs_from_prev_access(&row.p_access[0..NUM_WORDS_FIELD_ELEMENT]); | ||
| let p_y = limbs_from_prev_access(&row.p_access[NUM_WORDS_FIELD_ELEMENT..]); | ||
| let num_words_field_element = E::BaseField::NB_LIMBS / 4; |
There was a problem hiding this comment.
nit: here shouldn't we just use the NUM_WORDS trait on E?
|
|
||
| // a in the Weierstrass form: y^2 = x^3 + a * x + b. | ||
| let a = limbs_from_biguint::<AB, E::BaseField>(&E::a_int()); | ||
| // TODO: U32 can't be hardcoded here? |
core/src/utils/ec/edwards/mod.rs
Outdated
| @@ -6,6 +6,9 @@ use serde::{Deserialize, Serialize}; | |||
| use crate::utils::ec::field::{FieldParameters, MAX_NB_LIMBS}; | |||
| use crate::utils::ec::{AffinePoint, EllipticCurve, EllipticCurveParameters}; | |||
|
|
|||
| // The number of `u8` limbs in the base field of Ed25519. | |||
| const NUM_LIMBS: usize = 32; | |||
There was a problem hiding this comment.
can we clean up MAX_NB_LIMBS and NUM_LIMBS in here?
| @@ -38,6 +40,11 @@ impl FieldParameters for Bn254BaseField { | |||
| } | |||
| } | |||
|
|
|||
| impl NumLimbs for Bn254BaseField { | |||
| type Limbs = U16; | |||
There was a problem hiding this comment.
wait i think this should be u32, u62 lol, i was just trolling when i added this file
puma314
approved these changes
Mar 23, 2024
puma314
approved these changes
Mar 23, 2024
jtguibas
pushed a commit
that referenced
this pull request
Mar 29, 2024
Signed-off-by: 0xkanekiken <100861945+0xKanekiKen@users.noreply.github.com> Co-authored-by: 0xkanekiken <100861945+0xKanekiKen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<T, N: ArraySize>NumLimbstrait which hasLimbsandWitnessArraySizetypesgeneric_arrayfrom rustcrypto so we can have associated array lengths in traithybrid-arrayto const generic core arrays RustCrypto/traits#1481E::BaseFieldas NumLimbs (execute still hardcoded)