Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On every beat do is always one beat behind #2390

Closed
pikurasa opened this issue Jul 6, 2020 · 1 comment
Closed

On every beat do is always one beat behind #2390

pikurasa opened this issue Jul 6, 2020 · 1 comment
Assignees

Comments

@pikurasa
Copy link
Collaborator

pikurasa commented Jul 6, 2020

This can be observed in:

https://github.com/sugarlabs/musicblocks/files/4871015/Improvisation.html.zip

On every beat do starts the action on the second beat, not the first.

On every note do does exactly what I expect, at the right time.

I am a little confused because I know there is discussion of "before" and "after". However, the "on every note do" seems to be putting the action "inside the note value" whereas "on every beat do" is putting the action after the beat has occurred (and abruptly, as if it is outside of the note value clamp).

sksum added a commit to sksum/musicblocks that referenced this issue Aug 23, 2020
start beat events as soon as we encounter the on every beat do blok
sksum added a commit to sksum/musicblocks that referenced this issue Aug 24, 2020
This reverts commit 6e1319b.
@pikurasa
Copy link
Collaborator Author

I also got an error the first time I ran the code. It ran well the second time.

These are the errors I get the first time.

synthutils.js:1202 Uncaught TypeError: Cannot use 'in' operator to search for 'piano' in undefined
    at Synth.loadSynth (synthutils.js:1202)
    at Function.setTimbre (ToneActions.js:55)
    at SetTimbreBlock.flow (ToneBlocks.js:620)
    at Logo.runFromBlockNow (logo.js:1597)
    at logo.js:1474
11
turtle-singer.js:1024 Uncaught TypeError: Cannot use 'in' operator to search for 'piano' in undefined
    at Function.processNote (turtle-singer.js:1024)
    at __listener (RhythmActions.js:138)
    at a.b._dispatchEvent (VM452 easeljs.min.js:12)
    at a.b._dispatchEvent (VM452 easeljs.min.js:12)
    at a.b.dispatchEvent (VM452 easeljs.min.js:12)
    at Logo.runFromBlockNow (logo.js:1640)
    at logo.js:1474

sksum added a commit to sksum/musicblocks that referenced this issue Aug 27, 2020
* fix reference error

* fix sugarlabs#2390

start beat events as soon as we encounter the on every beat do blok

* Revert "fix sugarlabs#2390"

This reverts commit 6e1319b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants