Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix reference error #2534

Merged
merged 3 commits into from
Aug 25, 2020
Merged

fix reference error #2534

merged 3 commits into from
Aug 25, 2020

Conversation

sksum
Copy link
Member

@sksum sksum commented Aug 22, 2020 •
edited
Loading

please test #2513

@sksum sksum requested a review from meganindya August 22, 2020 23:35
@sksum
fix sugarlabs#2390
6e1319b 
start beat events as soon as we encounter the on every beat do blok
@sksum sksum mentioned this pull request Aug 23, 2020
Closed
@meganindya
Copy link
Member

Works the second time onwards.

First time it produces error:

synthutils.js:1512 Uncaught TypeError: Cannot read property 'electronic synth' of undefined
    at Synth.trigger (synthutils.js:1512)
    at __playnote (turtle-singer.js:1893)
    at Function.processNote (turtle-singer.js:2068)
    at __listener (RhythmActions.js:138)
    at a.b._dispatchEvent (VM1289 easeljs.min.js:12)
    at a.b._dispatchEvent (VM1289 easeljs.min.js:12)
    at a.b.dispatchEvent (VM1289 easeljs.min.js:12)
    at Logo.runFromBlockNow (logo.js:1640)
    at logo.js:1474
Uncaught TypeError: Cannot read property 'electronic synth' of undefined
    at Synth.trigger (synthutils.js:1512)
    at __playnote (turtle-singer.js:1893)
    at Function.processNote (turtle-singer.js:2068)
    at __listener (RhythmActions.js:138)
    at a.b._dispatchEvent (VM1289 easeljs.min.js:12)
    at a.b._dispatchEvent (VM1289 easeljs.min.js:12)
    at a.b.dispatchEvent (VM1289 easeljs.min.js:12)
    at Logo.runFromBlockNow (logo.js:1640)
    at logo.js:1474

as far as I remember, there's something with createDefaultSynth()

@sksum
Revert "fix sugarlabs#2390"
5f5d764 
This reverts commit 6e1319b.
@walterbender walterbender merged commit 3afc62b into sugarlabs:master Aug 25, 2020
sksum added a commit to sksum/musicblocks that referenced this pull request Aug 27, 2020
@sksum
fix reference error (sugarlabs#2534)
1ec18ed 
* fix reference error

* fix sugarlabs#2390

start beat events as soon as we encounter the on every beat do blok

* Revert "fix sugarlabs#2390"

This reverts commit 6e1319b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meganindya meganindya Awaiting requested review from meganindya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sksum @meganindya @walterbender