Fix Pagination component return type (#1635)

sumup-oss · Jun 30, 2022 · 5c2ea97 · 5c2ea97 · vercel · Jun 30, 2022
1 parent 5e4a9e7
commit 5c2ea97
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/swift-mails-cross.md b/.changeset/swift-mails-cross.md
@@ -0,0 +1,5 @@
+---
+'@sumup/circuit-ui': patch
+---
+
+Changed `Pagination` type from `ReactNode` to `ReactElement | null` to prevent a clash with React 18 types.
diff --git a/packages/circuit-ui/components/Pagination/Pagination.tsx b/packages/circuit-ui/components/Pagination/Pagination.tsx
@@ -13,7 +13,7 @@
  * limitations under the License.
  */
 
-import { ReactNode } from 'react';
+import { ReactElement } from 'react';
 import { css } from '@emotion/react';
 import { Theme } from '@sumup/design-tokens';
 import { ChevronLeft, ChevronRight } from '@sumup/icons';
@@ -102,7 +102,7 @@ export const Pagination = ({
   totalLabel,
   tracking = {},
   ...props
-}: PaginationProps): ReactNode => {
+}: PaginationProps): ReactElement | null => {
   if (
     process.env.NODE_ENV !== 'production' &&
     process.env.NODE_ENV !== 'test'