Fix Pagination component return type

[robinmetral]

Purpose

Currently, the Pagination component is typed as a ReactNode.

This can be a problem for apps using React 18, because ReactNode can be undefined, and undefined isn't a valid JSX component.

Approach and changes

Switch the return type to ReactElement | null.

This is more accurate, since the Pagination component never returns e.g. undefined, a string, or an array of ReactElements (all included in the definition of ReactNode).

It can either be null (when there are less than two pages) or a ReactElement otherwise.

Definition of done

• Development completed
• Reviewers assigned
• Unit and integration tests
• Meets minimum browser support
• Meets accessibility requirements

[sumup-clark]

Hey @robinmetral,
we are super excited that you are contributing! 🎉There's one more thing you need to do. Please accept our Contributor License Agreement. It helps you and us to collaborate on clear terms and focus on what we love most: code.

Thanks!

[changeset-bot]

🦋 Changeset detected

Latest commit: d250162

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sumup/circuit-ui	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
oss-circuit-ui	✅ Ready (Inspect)	Visit Preview	Jun 30, 2022 at 7:06AM (UTC)

[codecov]

Codecov Report

Merging #1635 (d250162) into main (5e4a9e7) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1635   +/-   ##
=======================================
  Coverage   91.54%   91.54%           
=======================================
  Files         195      195           
  Lines        4080     4080           
  Branches     1296     1296           
=======================================
  Hits         3735     3735           
  Misses        326      326           
  Partials       19       19           

Impacted Files	Coverage Δ
...es/circuit-ui/components/Pagination/Pagination.tsx	81.57% <100.00%> (ø)

[connor-baer]

Suggested change

	Changed `Pagination` type from `ReactNode` to `ReactElement | null` to prevent a clash with React 18 types.
	Changed `Pagination` return type from `ReactNode` to `ReactElement | null` to prevent a clash with React 18 types.

[connor-baer]

Aaah, Kodiak was too fast 😅